* [PATCH] libvendor/osm_vendor_ibumad_sa.c: remove useless "if" statement
@ 2010-09-07 15:13 Yevgeny Kliteynik
[not found] ` <4C8656B0.5050104-VPRAkNaXOzVS1MOuV/RT9w@public.gmane.org>
0 siblings, 1 reply; 4+ messages in thread
From: Yevgeny Kliteynik @ 2010-09-07 15:13 UTC (permalink / raw)
To: Sasha Khapyorsky, Linux RDMA
Content of p_query_req_copy is used in the function,
so no point checking if it's NULL before the free().
Signed-off-by: Yevgeny Kliteynik <kliteyn-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>
---
opensm/libvendor/osm_vendor_ibumad_sa.c | 3 +--
1 files changed, 1 insertions(+), 2 deletions(-)
diff --git a/opensm/libvendor/osm_vendor_ibumad_sa.c b/opensm/libvendor/osm_vendor_ibumad_sa.c
index 75bc303..1fdcc47 100644
--- a/opensm/libvendor/osm_vendor_ibumad_sa.c
+++ b/opensm/libvendor/osm_vendor_ibumad_sa.c
@@ -199,8 +199,7 @@ static void __osmv_sa_mad_err_cb(IN void *bind_context, IN osm_madw_t * p_madw)
if ((p_query_req_copy->flags & OSM_SA_FLAGS_SYNC) == OSM_SA_FLAGS_SYNC)
cl_event_signal(&p_bind->sync_event);
- if (p_query_req_copy)
- free(p_query_req_copy);
+ free(p_query_req_copy);
OSM_LOG_EXIT(p_bind->p_log);
}
--
1.6.2.4
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related [flat|nested] 4+ messages in thread[parent not found: <4C8656B0.5050104-VPRAkNaXOzVS1MOuV/RT9w@public.gmane.org>]
* Re: [PATCH] libvendor/osm_vendor_ibumad_sa.c: remove useless "if" statement [not found] ` <4C8656B0.5050104-VPRAkNaXOzVS1MOuV/RT9w@public.gmane.org> @ 2010-09-07 17:47 ` Hal Rosenstock [not found] ` <AANLkTingExvAshGM6uOQhy3TNFwH7dSrF6fWXYzGxke4-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> 2010-09-07 20:02 ` Sasha Khapyorsky 1 sibling, 1 reply; 4+ messages in thread From: Hal Rosenstock @ 2010-09-07 17:47 UTC (permalink / raw) To: kliteyn-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb; +Cc: Sasha Khapyorsky, Linux RDMA On Tue, Sep 7, 2010 at 11:13 AM, Yevgeny Kliteynik <kliteyn-VPRAkNaXOzVS1MOuV/RT9w@public.gmane.org> wrote: > Content of p_query_req_copy is used in the function, > so no point checking if it's NULL before the free(). > > Signed-off-by: Yevgeny Kliteynik <kliteyn-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org> > --- > opensm/libvendor/osm_vendor_ibumad_sa.c | 3 +-- Same change could be done for osm_vendor_mlx_sa.c too. -- Hal > 1 files changed, 1 insertions(+), 2 deletions(-) > > diff --git a/opensm/libvendor/osm_vendor_ibumad_sa.c b/opensm/libvendor/osm_vendor_ibumad_sa.c > index 75bc303..1fdcc47 100644 > --- a/opensm/libvendor/osm_vendor_ibumad_sa.c > +++ b/opensm/libvendor/osm_vendor_ibumad_sa.c > @@ -199,8 +199,7 @@ static void __osmv_sa_mad_err_cb(IN void *bind_context, IN osm_madw_t * p_madw) > if ((p_query_req_copy->flags & OSM_SA_FLAGS_SYNC) == OSM_SA_FLAGS_SYNC) > cl_event_signal(&p_bind->sync_event); > > - if (p_query_req_copy) > - free(p_query_req_copy); > + free(p_query_req_copy); > OSM_LOG_EXIT(p_bind->p_log); > } > > -- > 1.6.2.4 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-rdma" in > the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 4+ messages in thread
[parent not found: <AANLkTingExvAshGM6uOQhy3TNFwH7dSrF6fWXYzGxke4-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>]
* Re: [PATCH] libvendor/osm_vendor_ibumad_sa.c: remove useless "if" statement [not found] ` <AANLkTingExvAshGM6uOQhy3TNFwH7dSrF6fWXYzGxke4-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> @ 2010-09-07 18:20 ` Yevgeny Kliteynik 0 siblings, 0 replies; 4+ messages in thread From: Yevgeny Kliteynik @ 2010-09-07 18:20 UTC (permalink / raw) To: Hal Rosenstock; +Cc: Sasha Khapyorsky, Linux RDMA On 07-Sep-10 8:47 PM, Hal Rosenstock wrote: > On Tue, Sep 7, 2010 at 11:13 AM, Yevgeny Kliteynik > <kliteyn-VPRAkNaXOzVS1MOuV/RT9w@public.gmane.org> wrote: >> Content of p_query_req_copy is used in the function, >> so no point checking if it's NULL before the free(). >> >> Signed-off-by: Yevgeny Kliteynik<kliteyn-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org> >> --- >> opensm/libvendor/osm_vendor_ibumad_sa.c | 3 +-- > > Same change could be done for osm_vendor_mlx_sa.c too. Sure, thanks. -- Yevgeny > -- Hal > >> 1 files changed, 1 insertions(+), 2 deletions(-) >> >> diff --git a/opensm/libvendor/osm_vendor_ibumad_sa.c b/opensm/libvendor/osm_vendor_ibumad_sa.c >> index 75bc303..1fdcc47 100644 >> --- a/opensm/libvendor/osm_vendor_ibumad_sa.c >> +++ b/opensm/libvendor/osm_vendor_ibumad_sa.c >> @@ -199,8 +199,7 @@ static void __osmv_sa_mad_err_cb(IN void *bind_context, IN osm_madw_t * p_madw) >> if ((p_query_req_copy->flags& OSM_SA_FLAGS_SYNC) == OSM_SA_FLAGS_SYNC) >> cl_event_signal(&p_bind->sync_event); >> >> - if (p_query_req_copy) >> - free(p_query_req_copy); >> + free(p_query_req_copy); >> OSM_LOG_EXIT(p_bind->p_log); >> } >> >> -- >> 1.6.2.4 >> >> -- >> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in >> the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org >> More majordomo info at http://vger.kernel.org/majordomo-info.html >> > -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] libvendor/osm_vendor_ibumad_sa.c: remove useless "if" statement [not found] ` <4C8656B0.5050104-VPRAkNaXOzVS1MOuV/RT9w@public.gmane.org> 2010-09-07 17:47 ` Hal Rosenstock @ 2010-09-07 20:02 ` Sasha Khapyorsky 1 sibling, 0 replies; 4+ messages in thread From: Sasha Khapyorsky @ 2010-09-07 20:02 UTC (permalink / raw) To: kliteyn-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb; +Cc: Linux RDMA On 18:13 Tue 07 Sep , Yevgeny Kliteynik wrote: > Content of p_query_req_copy is used in the function, > so no point checking if it's NULL before the free(). > > Signed-off-by: Yevgeny Kliteynik <kliteyn-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org> Applied. Thanks. Sasha -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2010-09-07 20:02 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-09-07 15:13 [PATCH] libvendor/osm_vendor_ibumad_sa.c: remove useless "if" statement Yevgeny Kliteynik
[not found] ` <4C8656B0.5050104-VPRAkNaXOzVS1MOuV/RT9w@public.gmane.org>
2010-09-07 17:47 ` Hal Rosenstock
[not found] ` <AANLkTingExvAshGM6uOQhy3TNFwH7dSrF6fWXYzGxke4-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2010-09-07 18:20 ` Yevgeny Kliteynik
2010-09-07 20:02 ` Sasha Khapyorsky
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox