From: Ira Weiny <weiny2-i2BcT+NCU+M@public.gmane.org>
To: Hal Rosenstock <hal.rosenstock-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: Sasha Khapyorsky <sashak-smomgflXvOZWk0Htik3J/w@public.gmane.org>,
"linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [PATCH] libibmad/fields.c: Change all PortCounter names to match the Specification
Date: Wed, 8 Sep 2010 12:12:06 -0700 [thread overview]
Message-ID: <20100908121206.81c19f94.weiny2@llnl.gov> (raw)
In-Reply-To: <AANLkTinc5MGM6YEkeLrWT_m81LFm-JCtef_M5sw7sBw=@mail.gmail.com>
On Wed, 8 Sep 2010 04:24:28 -0700
Hal Rosenstock <hal.rosenstock-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote:
> On Tue, Sep 7, 2010 at 10:37 PM, Ira Weiny <weiny2-i2BcT+NCU+M@public.gmane.org> wrote:
> >
> > From: Ira Weiny <weiny2-i2BcT+NCU+M@public.gmane.org>
> > Date: Tue, 3 Aug 2010 10:40:56 -0700
> > Subject: [PATCH] libibmad/fields.c: Change all PortCounter names to match the Specification
> >
> > Signed-off-by: Ira Weiny <weiny2-i2BcT+NCU+M@public.gmane.org>
> > ---
> > libibmad/src/fields.c | 32 ++++++++++++++++----------------
> > 1 files changed, 16 insertions(+), 16 deletions(-)
>
> A number of diag scripts need changing to go along with these field
> name changes.
Correct.
New patch to follow,
Ira
>
> -- Hal
>
> > diff --git a/libibmad/src/fields.c b/libibmad/src/fields.c
> > index a5a510a..d992065 100644
> > --- a/libibmad/src/fields.c
> > +++ b/libibmad/src/fields.c
> > @@ -246,24 +246,24 @@ static const ib_field_t ib_mad_f[] = {
> > */
> > {BITSOFFS(8, 8), "PortSelect", mad_dump_uint},
> > {BITSOFFS(16, 16), "CounterSelect", mad_dump_hex},
> > - {BITSOFFS(32, 16), "SymbolErrors", mad_dump_uint},
> > - {BITSOFFS(48, 8), "LinkRecovers", mad_dump_uint},
> > - {BITSOFFS(56, 8), "LinkDowned", mad_dump_uint},
> > - {BITSOFFS(64, 16), "RcvErrors", mad_dump_uint},
> > - {BITSOFFS(80, 16), "RcvRemotePhysErrors", mad_dump_uint},
> > - {BITSOFFS(96, 16), "RcvSwRelayErrors", mad_dump_uint},
> > - {BITSOFFS(112, 16), "XmtDiscards", mad_dump_uint},
> > - {BITSOFFS(128, 8), "XmtConstraintErrors", mad_dump_uint},
> > - {BITSOFFS(136, 8), "RcvConstraintErrors", mad_dump_uint},
> > + {BITSOFFS(32, 16), "SymbolErrorCounter", mad_dump_uint},
> > + {BITSOFFS(48, 8), "LinkErrorRecoveryCounter", mad_dump_uint},
> > + {BITSOFFS(56, 8), "LinkDownedCounter", mad_dump_uint},
> > + {BITSOFFS(64, 16), "PortRcvErrors", mad_dump_uint},
> > + {BITSOFFS(80, 16), "PortRcvRemotePhysicalErrors", mad_dump_uint},
> > + {BITSOFFS(96, 16), "PortRcvSwitchRelayErrors", mad_dump_uint},
> > + {BITSOFFS(112, 16), "PortXmitDiscards", mad_dump_uint},
> > + {BITSOFFS(128, 8), "PortXmitConstraintErrors", mad_dump_uint},
> > + {BITSOFFS(136, 8), "PortRcvConstraintErrors", mad_dump_uint},
> > {BITSOFFS(144, 8), "CounterSelect2", mad_dump_hex},
> > - {BITSOFFS(152, 4), "LinkIntegrityErrors", mad_dump_uint},
> > - {BITSOFFS(156, 4), "ExcBufOverrunErrors", mad_dump_uint},
> > + {BITSOFFS(152, 4), "LocalLinkIntegrityErrors", mad_dump_uint},
> > + {BITSOFFS(156, 4), "ExcessiveBufferOverrunErrors", mad_dump_uint},
> > {BITSOFFS(176, 16), "VL15Dropped", mad_dump_uint},
> > - {192, 32, "XmtData", mad_dump_uint},
> > - {224, 32, "RcvData", mad_dump_uint},
> > - {256, 32, "XmtPkts", mad_dump_uint},
> > - {288, 32, "RcvPkts", mad_dump_uint},
> > - {320, 32, "XmtWait", mad_dump_uint},
> > + {192, 32, "PortXmitData", mad_dump_uint},
> > + {224, 32, "PortRcvData", mad_dump_uint},
> > + {256, 32, "PortXmitPkts", mad_dump_uint},
> > + {288, 32, "PortRcvPkts", mad_dump_uint},
> > + {320, 32, "PortXmitWait", mad_dump_uint},
> > {0, 0}, /* IB_PC_LAST_F */
> >
> > /*
> > --
> > 1.5.4.5
> >
> > --
> > To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
> > the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> > More majordomo info at http://*vger.kernel.org/majordomo-info.html
> >
>
--
Ira Weiny
Math Programmer/Computer Scientist
Lawrence Livermore National Lab
925-423-8008
weiny2-i2BcT+NCU+M@public.gmane.org
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2010-09-08 19:12 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-08 2:37 [PATCH] libibmad/fields.c: Change all PortCounter names to match the Specification Ira Weiny
[not found] ` <20100907193727.83c64672.weiny2-i2BcT+NCU+M@public.gmane.org>
2010-09-08 11:24 ` Hal Rosenstock
2010-09-08 19:12 ` Ira Weiny [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100908121206.81c19f94.weiny2@llnl.gov \
--to=weiny2-i2bct+ncu+m@public.gmane.org \
--cc=hal.rosenstock-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=sashak-smomgflXvOZWk0Htik3J/w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox