* [PATCH] opensm/osm_subnet.c: fixing small bug in error path
@ 2010-09-07 15:04 Yevgeny Kliteynik
[not found] ` <4C865486.4040909-VPRAkNaXOzVS1MOuV/RT9w@public.gmane.org>
0 siblings, 1 reply; 2+ messages in thread
From: Yevgeny Kliteynik @ 2010-09-07 15:04 UTC (permalink / raw)
To: Sasha Khapyorsky, Linux RDMA
Closing file on failure
Signed-off-by: Yevgeny Kliteynik <kliteyn-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>
---
opensm/opensm/osm_subnet.c | 4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/opensm/opensm/osm_subnet.c b/opensm/opensm/osm_subnet.c
index d5c5ab2..149ab85 100644
--- a/opensm/opensm/osm_subnet.c
+++ b/opensm/opensm/osm_subnet.c
@@ -1163,8 +1163,10 @@ int osm_subn_parse_conf_file(char *file_name, osm_subn_opt_t * p_opts)
cl_log_event("OpenSM", CL_LOG_INFO, line, NULL, 0);
p_opts->config_file = file_name;
- if (!p_opts->file_opts && !(p_opts->file_opts = malloc(sizeof(*p_opts))))
+ if (!p_opts->file_opts && !(p_opts->file_opts = malloc(sizeof(*p_opts)))) {
+ fclose(opts_file);
return -1;
+ }
memcpy(p_opts->file_opts, p_opts, sizeof(*p_opts));
while (fgets(line, 1023, opts_file) != NULL) {
--
1.6.2.4
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-09-09 14:40 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-09-07 15:04 [PATCH] opensm/osm_subnet.c: fixing small bug in error path Yevgeny Kliteynik
[not found] ` <4C865486.4040909-VPRAkNaXOzVS1MOuV/RT9w@public.gmane.org>
2010-09-09 14:40 ` Sasha Khapyorsky
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox