From: Jason Gunthorpe <jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
To: Or Gerlitz <ogerlitz-smomgflXvOZWk0Htik3J/w@public.gmane.org>
Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Roland Dreier <rdreier-FYB4Gu1CFyUAvxtiuMwx3w@public.gmane.org>
Subject: Re: [PATCH] [IPOIB] Check for a MTU overflow on the GSO path
Date: Wed, 15 Sep 2010 16:33:57 -0600 [thread overview]
Message-ID: <20100915223356.GA14549@obsidianresearch.com> (raw)
In-Reply-To: <4C90BBBB.6040503-smomgflXvOZWk0Htik3J/w@public.gmane.org>
On Wed, Sep 15, 2010 at 02:27:39PM +0200, Or Gerlitz wrote:
> Jason Gunthorpe wrote:
> >The code to check that the send packet size is less than the MTU is only
> >invoked in the non-GSO case. This lets packets which are too large pass
> >through.
> Jason,
>
> Did you get here following code inspection or during debugging? if the
> latter, what does it take to reproduce that?
I noticed it when I was working on the code for the patch after, IPoIB
was still causing MTU discards in my network and that was why. I
didn't try it with CM mode, but I can't see that it would be any
different.
In my testing what I noticed was that the first few packets of a TCP
session triggered the PMTU stuff, but immediately after were a few
GSO packets that tried to go through with the larger MTU. They were
resent fairly quickly with the correct MTU due to the PMTU fixup that
happened.
Jason
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2010-09-15 22:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-02 23:11 [PATCH] [IPOIB] Check for a MTU overflow on the GSO path Jason Gunthorpe
[not found] ` <20100902231140.GW24971-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2010-09-15 12:27 ` Or Gerlitz
[not found] ` <4C90BBBB.6040503-smomgflXvOZWk0Htik3J/w@public.gmane.org>
2010-09-15 22:33 ` Jason Gunthorpe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100915223356.GA14549@obsidianresearch.com \
--to=jgunthorpe-epgobjl8dl3ta4ec/59zmfatqe2ktcn/@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=ogerlitz-smomgflXvOZWk0Htik3J/w@public.gmane.org \
--cc=rdreier-FYB4Gu1CFyUAvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox