From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Hemminger Subject: Re: [PATCH] SIW: Module initialization Date: Wed, 6 Oct 2010 15:26:33 -0700 Message-ID: <20101006152633.1f498824@nehalam> References: <1286261640-5121-1-git-send-email-bmt@zurich.ibm.com> <20101006070242.3ca5a6d9@s6510> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Sender: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Bart Van Assche Cc: Bernard Metzler , netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-rdma@vger.kernel.org On Wed, 6 Oct 2010 18:06:52 +0200 Bart Van Assche wrote: > On Wed, Oct 6, 2010 at 12:02 AM, Stephen Hemminger > wrote: > > On Tue, 5 Oct 2010 12:57:21 +0200 > > Bart Van Assche wrote: > > > >> > + * TODO: Dynamic device management (network device registration/removal). > >> > >> The current implementation is such that one siw device is created for > >> each network device found at kernel module load time. That means that > >> you force the user to load the siw kernel module after all other > >> kernel modules that register a network device. I'm not sure that's a > >> good idea. > > > > Then device should be controlled by a netlink (rtnl_link_ops) style > > interface see vlan_netlink.c. Using netlink is extensible and provides > > a cleaner interface than all these other parameterization methods. > > That will be a lot more work to implement than what Jason proposed: > adding a sysfs variable per Ethernet driver, e.g. > /sys/class/net/eth0/enable_iwarp. But if we let code in with that API, then we have to maintain it. Netlink is the way to go. -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html