From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ira Weiny Subject: Re: ib mad definitions Date: Tue, 19 Oct 2010 18:32:57 -0700 Message-ID: <20101019183257.3f609c45.weiny2@llnl.gov> References: <20101019102244.21cd2b1e.weiny2@llnl.gov> <20101019212926.GH10362@obsidianresearch.com> <20101020010958.GA413@obsidianresearch.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20101020010958.GA413-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org> Sender: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Jason Gunthorpe Cc: "Hefty, Sean" , Hal Rosenstock , "linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , Sasha Khapyorsky List-Id: linux-rdma@vger.kernel.org On Tue, 19 Oct 2010 18:09:58 -0700 Jason Gunthorpe wrote: > On Tue, Oct 19, 2010 at 06:00:51PM -0700, Hefty, Sean wrote: > > > Can we at least agree on the usage of these structures first? Are the > > > constants going to be in host or network byte order? > > > > I was simply suggesting to 'move' some of the existing structures and defines. > > But they are horrible and little used outside opensm right now, you > really want to commit to that forever? Not everything is horrible. And if it is we can fix it. But I think defining "yet another" header with the same functionality is worse. Like it or not ib_types is there. If you don't remove/fix it, someone will find it and use it. How does that make things cleaner just because there is something "clean" somewhere else? Someone will find ib_types use it. I still feel this is the best first step at getting rid of ib_types.h (at least as it currently stands). Ira > > Jason -- Ira Weiny Math Programmer/Computer Scientist Lawrence Livermore National Lab 925-423-8008 weiny2-i2BcT+NCU+M@public.gmane.org -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html