From: Eli Cohen <eli-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>
To: Roland Dreier <rdreier-FYB4Gu1CFyUAvxtiuMwx3w@public.gmane.org>
Cc: RDMA list <linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [PATCHv10 08/12] mlx4: Add support for IBoE - address resolution
Date: Thu, 21 Oct 2010 09:27:03 +0200 [thread overview]
Message-ID: <20101021072703.GA1912@mtldesk30> (raw)
In-Reply-To: <adazku85dcf.fsf-FYB4Gu1CFyUAvxtiuMwx3w@public.gmane.org>
On Wed, Oct 20, 2010 at 10:22:56PM -0700, Roland Dreier wrote:
> Just curious -- what's up with this change here? Is this connected to
> IBoE support, or is this an independent fix?
It is required for proper distribution of IBoE multicast packets while
still not hurting the mlx4_en driver's operation.
> Also as far as I can tell this variable sgid is write-only (ie you do
> the ib_get_cached_gid() but then never do anything with the value that
> that returns). Am I missing something subtle?
>
It is not required in the context of this patch. It should have been
part of patch 12/12 which adds VLAN support, in which case it is used
to extract the required VLAN ID.
Roland, would you like me to send patches 8-12 again with this fixed?
>
> Finally this patch would have been easier to review without extraneous
> whitespace noise like
>
Sorry about that. I pass them through checkpatch but this must have
been hiden within the "line over ..." messages.
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2010-10-21 7:27 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-26 14:18 [PATCHv10 08/12] mlx4: Add support for IBoE - address resolution Eli Cohen
2010-10-21 5:22 ` Roland Dreier
[not found] ` <adazku85dcf.fsf-FYB4Gu1CFyUAvxtiuMwx3w@public.gmane.org>
2010-10-21 7:27 ` Eli Cohen [this message]
2010-10-21 19:48 ` Roland Dreier
[not found] ` <adazku78gzz.fsf-FYB4Gu1CFyUAvxtiuMwx3w@public.gmane.org>
2010-10-21 22:51 ` Eli Cohen
2010-10-22 4:15 ` Roland Dreier
2010-10-21 19:57 ` Roland Dreier
[not found] ` <adavd4v8gk4.fsf-FYB4Gu1CFyUAvxtiuMwx3w@public.gmane.org>
2010-10-21 22:54 ` Eli Cohen
2010-10-21 21:14 ` Roland Dreier
[not found] ` <adad3r38d0c.fsf-FYB4Gu1CFyUAvxtiuMwx3w@public.gmane.org>
2010-10-21 21:15 ` Roland Dreier
[not found] ` <ada8w1r8cxo.fsf-FYB4Gu1CFyUAvxtiuMwx3w@public.gmane.org>
2010-10-21 23:03 ` Eli Cohen
2010-10-22 4:15 ` Roland Dreier
[not found] ` <adazku6yiag.fsf-FYB4Gu1CFyUAvxtiuMwx3w@public.gmane.org>
2010-10-22 12:24 ` Eli Cohen
2010-10-21 23:01 ` Eli Cohen
2010-10-22 15:59 ` Or Gerlitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101021072703.GA1912@mtldesk30 \
--to=eli-ldsdmyg8hgv8yrgs2mwiifqbs+8scbdb@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=rdreier-FYB4Gu1CFyUAvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox