From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eli Cohen Subject: Re: [PATCHv10 08/12] mlx4: Add support for IBoE - address resolution Date: Fri, 22 Oct 2010 01:01:41 +0200 Message-ID: <20101021230140.GC6367@mtldesk30> References: <20100826141851.GI8795@mtldesk30> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Roland Dreier Cc: RDMA list List-Id: linux-rdma@vger.kernel.org On Thu, Oct 21, 2010 at 02:14:11PM -0700, Roland Dreier wrote: > > enum { > > /* > > * Largest possible UD header: send with GRH and immediate data. > > + * 4 bytes added to accommodate for eth header instead of lrh > > */ > > - MLX4_IB_UD_HEADER_SIZE = 72, > > + MLX4_IB_UD_HEADER_SIZE = 76, > > I don't understand this change either. As far as I can tell, a 14-byte > Ethernet header is 6 bytes longer than an 8-byte LRH, and with .1q the > 18-byte header will require 10 bytes more than the LRH. So shouldn't > this value be 78 in this patch and updated to 82 in the VLAN patch? > > (It probably works in practice because the allocation of sqp structs > gets rounded up enough) > Agree, I made a wrong calculation. -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html