* [PATCH] [IB/QIB] Fix QIB early error reporting prints
@ 2010-10-22 20:41 Jason Gunthorpe
[not found] ` <20101022204124.GB30241-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
0 siblings, 1 reply; 3+ messages in thread
From: Jason Gunthorpe @ 2010-10-22 20:41 UTC (permalink / raw)
To: Ralph Campbell, RDMA list
Noticed this odd looking thing in dmesg:
ib_qib 0000:02:00.0: <3>ib_qib: Unable to enable pcie error reporting: -5
Which is due to a bad use of dev_info.
Signed-off-by: Jason Gunthorpe <jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
---
drivers/infiniband/hw/qib/qib.h | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/infiniband/hw/qib/qib.h b/drivers/infiniband/hw/qib/qib.h
index 3593983..0268326 100644
--- a/drivers/infiniband/hw/qib/qib.h
+++ b/drivers/infiniband/hw/qib/qib.h
@@ -1402,7 +1402,7 @@ extern struct mutex qib_mutex;
*/
#define qib_early_err(dev, fmt, ...) \
do { \
- dev_info(dev, KERN_ERR QIB_DRV_NAME ": " fmt, ##__VA_ARGS__); \
+ dev_err(dev, fmt, ##__VA_ARGS__); \
} while (0)
#define qib_dev_err(dd, fmt, ...) \
--
1.6.0.4
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related [flat|nested] 3+ messages in thread[parent not found: <20101022204124.GB30241-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>]
* RE: [PATCH] [IB/QIB] Fix QIB early error reporting prints [not found] ` <20101022204124.GB30241-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org> @ 2010-10-22 21:35 ` Ralph Campbell [not found] ` <35AAF1E4A771E142979F27B51793A488873ABE076E-HolNjIBXvBOXx9kJd3VG2h2eb7JE58TQ@public.gmane.org> 0 siblings, 1 reply; 3+ messages in thread From: Ralph Campbell @ 2010-10-22 21:35 UTC (permalink / raw) To: Jason Gunthorpe, RDMA list Acked-by: Ralph Campbell <ralph.campbell-h88ZbnxC6KDQT0dZR+AlfA@public.gmane.org> ________________________________________ From: Jason Gunthorpe [jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org] Sent: Friday, October 22, 2010 1:41 PM To: Ralph Campbell; RDMA list Subject: [PATCH] [IB/QIB] Fix QIB early error reporting prints Noticed this odd looking thing in dmesg: ib_qib 0000:02:00.0: <3>ib_qib: Unable to enable pcie error reporting: -5 Which is due to a bad use of dev_info. Signed-off-by: Jason Gunthorpe <jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org> --- drivers/infiniband/hw/qib/qib.h | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/infiniband/hw/qib/qib.h b/drivers/infiniband/hw/qib/qib.h index 3593983..0268326 100644 --- a/drivers/infiniband/hw/qib/qib.h +++ b/drivers/infiniband/hw/qib/qib.h @@ -1402,7 +1402,7 @@ extern struct mutex qib_mutex; */ #define qib_early_err(dev, fmt, ...) \ do { \ - dev_info(dev, KERN_ERR QIB_DRV_NAME ": " fmt, ##__VA_ARGS__); \ + dev_err(dev, fmt, ##__VA_ARGS__); \ } while (0) #define qib_dev_err(dd, fmt, ...) \ -- 1.6.0.4 -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply related [flat|nested] 3+ messages in thread
[parent not found: <35AAF1E4A771E142979F27B51793A488873ABE076E-HolNjIBXvBOXx9kJd3VG2h2eb7JE58TQ@public.gmane.org>]
* Re: [PATCH] [IB/QIB] Fix QIB early error reporting prints [not found] ` <35AAF1E4A771E142979F27B51793A488873ABE076E-HolNjIBXvBOXx9kJd3VG2h2eb7JE58TQ@public.gmane.org> @ 2010-10-23 5:18 ` Roland Dreier 0 siblings, 0 replies; 3+ messages in thread From: Roland Dreier @ 2010-10-23 5:18 UTC (permalink / raw) To: Ralph Campbell; +Cc: Jason Gunthorpe, RDMA list thanks, applied. -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2010-10-23 5:18 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-10-22 20:41 [PATCH] [IB/QIB] Fix QIB early error reporting prints Jason Gunthorpe
[not found] ` <20101022204124.GB30241-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2010-10-22 21:35 ` Ralph Campbell
[not found] ` <35AAF1E4A771E142979F27B51793A488873ABE076E-HolNjIBXvBOXx9kJd3VG2h2eb7JE58TQ@public.gmane.org>
2010-10-23 5:18 ` Roland Dreier
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox