[PATCH] mlx4: properly mask MGM entry members count

[PATCH] mlx4: properly mask MGM entry members count

[Eli Cohen]

The members_count field size is 24 bits so mask it properly when reading it.

Signed-off-by: Eli Cohen <eli-VPRAkNaXOzVS1MOuV/RT9w@public.gmane.org>
---
 drivers/net/mlx4/mcg.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/net/mlx4/mcg.c b/drivers/net/mlx4/mcg.c
index c4f88b7..fff20fc 100644
--- a/drivers/net/mlx4/mcg.c
+++ b/drivers/net/mlx4/mcg.c
@@ -187,7 +187,7 @@ int mlx4_multicast_attach(struct mlx4_dev *dev, struct mlx4_qp *qp, u8 gid[16],
 		memcpy(mgm->gid, gid, 16);
 	}
 
-	members_count = be32_to_cpu(mgm->members_count);
+	members_count = be32_to_cpu(mgm->members_count) & 0xffffff;
 	if (members_count == MLX4_QP_PER_MGM) {
 		mlx4_err(dev, "MGM at index %x is full.\n", index);
 		err = -ENOMEM;
-- 
1.6.0.2

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] mlx4: properly mask MGM entry members count

[Aleksey Senin]

On Mon, Nov 15, 2010 at 4:08 PM, Eli Cohen <eli-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org> wrote:
> The members_count field size is 24 bits so mask it properly when reading it.
>
> Signed-off-by: Eli Cohen <eli-VPRAkNaXOzVS1MOuV/RT9w@public.gmane.org>
> ---
>  drivers/net/mlx4/mcg.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/net/mlx4/mcg.c b/drivers/net/mlx4/mcg.c
> index c4f88b7..fff20fc 100644
> --- a/drivers/net/mlx4/mcg.c
> +++ b/drivers/net/mlx4/mcg.c
> @@ -187,7 +187,7 @@ int mlx4_multicast_attach(struct mlx4_dev *dev, struct mlx4_qp *qp, u8 gid[16],
>                memcpy(mgm->gid, gid, 16);
>        }
>
> -       members_count = be32_to_cpu(mgm->members_count);
> +       members_count = be32_to_cpu(mgm->members_count) & 0xffffff;
>        if (members_count == MLX4_QP_PER_MGM) {
>                mlx4_err(dev, "MGM at index %x is full.\n", index);
>                err = -ENOMEM;
> --
> 1.6.0.2
>

Don't you need to do the same when detaching?
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] mlx4: properly mask MGM entry members count

[Roland Dreier]

 > The members_count field size is 24 bits so mask it properly when reading it.

what's the impact of this?  Does this actually fix something seen in
practice or is it just found by inspection?

 - R.
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] mlx4: properly mask MGM entry members count

[Eli Cohen]

On Tue, Nov 16, 2010 at 11:38:45AM +0200, Aleksey Senin wrote:
> On Mon, Nov 15, 2010 at 4:08 PM, Eli Cohen <eli-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org> wrote:
> 
> Don't you need to do the same when detaching?

Yes, indeed. It was in the original OFED patch but somehow I failed to
include that hunk.
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] mlx4: properly mask MGM entry members count

[Eli Cohen]

On Tue, Nov 16, 2010 at 08:11:21AM -0800, Roland Dreier wrote:
>  > The members_count field size is 24 bits so mask it properly when reading it.
> 
> what's the impact of this?  Does this actually fix something seen in
> practice or is it just found by inspection?
> 

We need this patch as the MS byte is used now to encode the protocol
of the multicast address. I need to resend since the patch is missing
handling in the dettach function.
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] mlx4: properly mask MGM entry members count

[Roland Dreier]

 > We need this patch as the MS byte is used now to encode the protocol
 > of the multicast address. I need to resend since the patch is missing
 > handling in the dettach function.

Where is the change in handling in the members_count field?  In the firmware?

 - R.
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] mlx4: properly mask MGM entry members count

[Eli Cohen]

On Tue, Nov 16, 2010 at 02:43:46PM -0800, Roland Dreier wrote:
> 
> Where is the change in handling in the members_count field?  In the firmware?
> 
The firmware now distinguishes between differnet multicast addresses
according to a protocol field located in the high MS byte which
previously was reserved. The patches that Alekseys will will probably
send later make use of this.
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] mlx4: properly mask MGM entry members count

[Roland Dreier]

 > > Where is the change in handling in the members_count field?  In the firmware?
 > > 
 > The firmware now distinguishes between differnet multicast addresses
 > according to a protocol field located in the high MS byte which
 > previously was reserved. The patches that Alekseys will will probably
 > send later make use of this.

OK, so what you seem to be saying is that this patch is not fixing
anything until we add Alekseys patches?

 - R.
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] mlx4: properly mask MGM entry members count

[Eli Cohen]

On Wed, Nov 17, 2010 at 09:38:47AM -0800, Roland Dreier wrote:
>  > > Where is the change in handling in the members_count field?  In the firmware?
>  > > 
>  > The firmware now distinguishes between differnet multicast addresses
>  > according to a protocol field located in the high MS byte which
>  > previously was reserved. The patches that Alekseys will will probably
>  > send later make use of this.
> 
> OK, so what you seem to be saying is that this patch is not fixing
> anything until we add Alekseys patches?
> 
It only keeps the code and the PRM in sync.
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] mlx4: properly mask MGM entry members count

[Aleksey Senin]

On Thu, Nov 18, 2010 at 8:51 AM, Eli Cohen <eli-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org> wrote:
> On Wed, Nov 17, 2010 at 09:38:47AM -0800, Roland Dreier wrote:
>>  > > Where is the change in handling in the members_count field?  In the firmware?
>>  > >
>>  > The firmware now distinguishes between differnet multicast addresses
>>  > according to a protocol field located in the high MS byte which
>>  > previously was reserved. The patches that Alekseys will will probably
>>  > send later make use of this.
>>
>> OK, so what you seem to be saying is that this patch is not fixing
>> anything until we add Alekseys patches?
>>
> It only keeps the code and the PRM in sync.
> --

RAW_ETH patches cannot be applied without it, so we really need this masking.
In addition, Yevgeny's mlx SRIOV patches
(http://marc.info/?l=linux-rdma&m=127619666403521&w=2 ),
also using this field - there are changes in find_mgm function.
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] mlx4: properly mask MGM entry members count

[Or Gerlitz]

Aleksey Senin wrote:
> RAW_ETH patches cannot be applied without it, so we really need this masking.

So Maybe it would be easier to review and merge if you add this patch to the raw qp patch set
you mentioned

Or.
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] mlx4: properly mask MGM entry members count

[Alekseys Senin]

On Thu, 2010-11-25 at 10:36 +0200, Or Gerlitz wrote:
> Aleksey Senin wrote:
> > RAW_ETH patches cannot be applied without it, so we really need this masking.
> 
> So Maybe it would be easier to review and merge if you add this patch to the raw qp patch set
> you mentioned
> 
> Or.

I don't think that RAW_ETH patches should contain fixes for Mellanox
driver implementation and make it working according to Mellanox PRM.
In any case, Eli sent patch that easy to review and merge.
In addition, even if I include this change to my series, there is a
chance that from the whole set, will be accepted only this one, and the
rest will be accepted later ;-)
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] mlx4: properly mask MGM entry members count

[Aleksey Senin]

Hello, Roland.

I afraid that you  overloaded with dozen of e-mails and missed this
question, so I'd ask you again. Is there any reason why this
members_count patch cannot be applied?

On Thu, Nov 25, 2010 at 10:56 AM, Alekseys Senin <alekseys-smomgflXvOZWk0Htik3J/w@public.gmane.org> wrote:
> On Thu, 2010-11-25 at 10:36 +0200, Or Gerlitz wrote:
>> Aleksey Senin wrote:
>> > RAW_ETH patches cannot be applied without it, so we really need this masking.
>>
>> So Maybe it would be easier to review and merge if you add this patch to the raw qp patch set
>> you mentioned
>>
>> Or.
>
> I don't think that RAW_ETH patches should contain fixes for Mellanox
> driver implementation and make it working according to Mellanox PRM.
> In any case, Eli sent patch that easy to review and merge.
> In addition, even if I include this change to my series, there is a
> chance that from the whole set, will be accepted only this one, and the
> rest will be accepted later ;-)
>
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] mlx4: properly mask MGM entry members count

[Roland Dreier]

 > I afraid that you  overloaded with dozen of e-mails and missed this
 > question, so I'd ask you again. Is there any reason why this
 > members_count patch cannot be applied?

No, it is fine.  I will merge it for 2.6.38.  However this long thread
should (I hope) show how the changelog could be improved -- if the
original patch had said why the patch was needed then we could have
avoided all this long discussion.

 - R.
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] mlx4: properly mask MGM entry members count

[Aleksey Senin]

On Mon, Nov 29, 2010 at 7:34 PM, Roland Dreier <rdreier-FYB4Gu1CFyUAvxtiuMwx3w@public.gmane.org> wrote:
>  > I afraid that you  overloaded with dozen of e-mails and missed this
>  > question, so I'd ask you again. Is there any reason why this
>  > members_count patch cannot be applied?
>
> No, it is fine.  I will merge it for 2.6.38.  However this long thread
> should (I hope) show how the changelog could be improved -- if the
> original patch had said why the patch was needed then we could have
> avoided all this long discussion.
>
>  - R.

Excellent news, thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html