From: Sasha Khapyorsky <sashak-smomgflXvOZWk0Htik3J/w@public.gmane.org>
To: Hal Rosenstock <hal-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>
Cc: Ira Weiny <weiny2-i2BcT+NCU+M@public.gmane.org>,
linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH] infiniband-diags/iblinkinfo.c: Limit some queries to switches
Date: Tue, 30 Nov 2010 17:41:28 +0200 [thread overview]
Message-ID: <20101130154128.GH11898@me> (raw)
In-Reply-To: <4CC81F4B.4090600-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>
On 08:47 Wed 27 Oct , Hal Rosenstock wrote:
> infiniband-diags/iblinkinfo.c: Limit certain queries to switches
>
> iblinkinfo man page says:
> DESCRIPTION
> iblinkinfo reports the link info for each port of each switch
> active in
> the IB fabric.
>
> OPTIONS
> -S <guid>
> Output only the switch specified by <guid> (hex format)
>
> -D <direct_route>
> Output only the switch specified by the direct route path.
>
> Queries by DR path or GUID should (also) be limited to switches.
>
> Signed-off-by: Hal Rosenstock <hal-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
Applied by hands (the patch is malformed). Thanks.
Sasha
> ---
> diff --git a/infiniband-diags/src/iblinkinfo.c
> b/infiniband-diags/src/iblinkinfo.c
> index d0c9b13..b129cb6 100644
> --- a/infiniband-diags/src/iblinkinfo.c
> +++ b/infiniband-diags/src/iblinkinfo.c
> @@ -2,6 +2,7 @@
> * Copyright (c) 2004-2009 Voltaire Inc. All rights reserved.
> * Copyright (c) 2007 Xsigo Systems Inc. All rights reserved.
> * Copyright (c) 2008 Lawrence Livermore National Lab. All rights
> reserved.
> + * Copyright (c) 2010 Mellanox Technologies LTD. All rights reserved.
> *
> * This software is available to you under a choice of one of two
> * licenses. You may choose to be licensed under the terms of the GNU
> @@ -387,7 +388,7 @@ int main(int argc, char **argv)
>
> if (!all && guid_str) {
> ibnd_node_t *sw = ibnd_find_node_guid(fabric, guid);
> - if (sw)
> + if (sw && sw->type == IB_NODE_TYPE_SWITCH)
> print_switch(sw, NULL);
> else
> fprintf(stderr, "Failed to find switch: %s\n",
> @@ -402,7 +403,7 @@ int main(int argc, char **argv)
> mad_decode_field(ni, IB_NODE_GUID_F, &(guid));
>
> sw = ibnd_find_node_guid(fabric, guid);
> - if (sw)
> + if (sw && sw->type == IB_NODE_TYPE_SWITCH)
> print_switch(sw, NULL);
> else
> fprintf(stderr, "Failed to find switch: %s\n", dr_path);
> --
> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
> the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2010-11-30 15:41 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-27 12:47 [PATCH] infiniband-diags/iblinkinfo.c: Limit some queries to switches Hal Rosenstock
[not found] ` <4CC81F4B.4090600-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>
2010-11-30 15:41 ` Sasha Khapyorsky [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101130154128.GH11898@me \
--to=sashak-smomgflxvozwk0htik3j/w@public.gmane.org \
--cc=hal-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=weiny2-i2BcT+NCU+M@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox