Re: [PATCH] replace (long*)(long) casting with transportable data type (uintptr_t)

[Sasha Khapyorsky <sashak-smomgflXvOZWk0Htik3J/w@public.gmane.org>]

On 14:12 Thu 09 Sep     , Stan C. Smith wrote:
> 
> Hello,
>   In osm_vendor_ibumad_sa.c the casting of a pointer to a long causes data truncation problems in 64-bit Windows where sizeof(long)
> != sizeof(void*).
> 'uintptr_t' is correct in both operating environments.

Wouldn't it be better to remove those additional castings at all?
Like below?

> 
> thank you,
> 
> stan.
> 
> signed-off-by: stan smith <stan.smith-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
> 
> diff --git a/opensm/libvendor/osm_vendor_ibumad_sa.c b/opensm/libvendor/osm_vendor_ibumad_sa.c
> index 1fdcc47..9180972 100644
> --- a/opensm/libvendor/osm_vendor_ibumad_sa.c
> +++ b/opensm/libvendor/osm_vendor_ibumad_sa.c
> @@ -85,7 +85,7 @@ __osmv_sa_mad_rcv_cb(IN osm_madw_t * p_madw,
>  
>  	/* obtain the sent context since we store it during send in the ni_ctx */
>  	p_query_req_copy =
> -	    (osmv_query_req_t *) (long *)(long)(p_req_madw->context.ni_context.
> +	    (osmv_query_req_t *) (uintptr_t)(p_req_madw->context.ni_context.
>  						node_guid);

	p_query_req_copy = (osmv_query_req_t *) p_req_madw->context.ni_context.node_guid;

>  
>  	/* provide the context of the original request in the result */
> @@ -181,7 +181,7 @@ static void __osmv_sa_mad_err_cb(IN void *bind_context, IN osm_madw_t * p_madw)
>  
>  	/* Obtain the sent context etc */
>  	p_query_req_copy =
> -	    (osmv_query_req_t *) (long *)(long)(p_madw->context.ni_context.
> +	    (osmv_query_req_t *) (uintptr_t)(p_madw->context.ni_context.
>  						node_guid);

 	p_query_req_copy = (osmv_query_req_t *) p_madw->context.ni_context.node_guid;

>  
>  	/* provide the context of the original request in the result */
> @@ -433,7 +433,7 @@ __osmv_send_sa_req(IN osmv_sa_bind_info_t * p_bind,
>  	}
>  	*p_query_req_copy = *p_query_req;
>  	p_madw->context.ni_context.node_guid =
> -	    (ib_net64_t) (long)p_query_req_copy;
> +	    (ib_net64_t) (uintptr_t)p_query_req_copy;

	p_madw->context.ni_context.node_guid = (ib_net64_t) p_query_req_copy;

?

Sasha

>  
>  	/* we can support async as well as sync calls */
>  	sync = ((p_query_req->flags & OSM_SA_FLAGS_SYNC) == OSM_SA_FLAGS_SYNC);
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html