Re: [PATCH] replace (long*)(long) casting with transportable data type (uintptr_t)

[Jason Gunthorpe <jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>]

On Tue, Nov 30, 2010 at 08:57:54PM +0200, Sasha Khapyorsky wrote:
> On 10:22 Tue 30 Nov     , Hefty, Sean wrote:
> > > Wouldn't it be better to remove those additional castings at all?
> > > Like below?
> > > 
> > ..
> > > 	p_query_req_copy = (osmv_query_req_t *) p_req_madw->context.ni_context.node_guid;
> > 
> > I think the Windows compiler will complain about data loss on a 32-bit system.
> 
> p_req_madw->context.ni_context.node_guid has 64 bits type.

But the pointer has 32 bits, so the compiler warns you it chucked the
upper 32 bits of node_guid.

The correct cast in C99 is (osmv_query_req_t *)(unitptr_t)

But one should look upon all of these with great suspicion and take a
moment to figure out where the original non-pointer came from. It
better not be from network data or you have a security problem.

Just reading the line from here looks insane, casting a GUID to a
pointer? :)

Jason
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html