From: Tejun Heo <tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
To: Bart Van Assche <bvanassche-HInyCGIudOg@public.gmane.org>
Cc: Roland Dreier <rdreier-FYB4Gu1CFyUAvxtiuMwx3w@public.gmane.org>,
David Dillow <dillowda-1Heg1YXhbW8@public.gmane.org>,
linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [GIT] lock scaling and bug fixes for 2.6.38
Date: Tue, 11 Jan 2011 18:43:40 +0100 [thread overview]
Message-ID: <20110111174340.GD15933@htj.dyndns.org> (raw)
In-Reply-To: <AANLkTikEnR6pjLy-L08UUbVdwS5f3k0+EutA-SrDVHMT-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
Hello,
On Tue, Jan 11, 2011 at 06:29:52PM +0100, Bart Van Assche wrote:
> On Tue, Jan 11, 2011 at 2:45 AM, Roland Dreier <rdreier-FYB4Gu1CFyUAvxtiuMwx3w@public.gmane.org> wrote:
> >
> > > git://git.kernel.org/pub/scm/linux/kernel/git/dad/srp-initiator.git srp-lock-scaling
> >
> > Thanks, pulled.
> >
> > Will try to merge Tejun's work queue patch shortly.
>
> Maybe it's a good idea to add a comment above the declaration of the
> global variable "extern struct workqueue_struct *ib_wq;" that explains
> that that variable has been added during the work queue conversion and
> that the preferred approach for new code is to define a new work queue
> instead of using ib_wq ?
But why is defining more workqueues preferred? Unless there's a
specific need, using what's already there (system or ib_wq) should be
preferable.
Thank you.
--
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2011-01-11 17:43 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-10 22:45 [GIT] lock scaling and bug fixes for 2.6.38 David Dillow
[not found] ` <1294699530.3038.27.camel-1q1vX8mYZiGLUyTwlgNVppKKF0rrzTr+@public.gmane.org>
2011-01-11 1:45 ` Roland Dreier
[not found] ` <adak4ic6wmo.fsf-FYB4Gu1CFyUAvxtiuMwx3w@public.gmane.org>
2011-01-11 17:29 ` Bart Van Assche
[not found] ` <AANLkTikEnR6pjLy-L08UUbVdwS5f3k0+EutA-SrDVHMT-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2011-01-11 17:43 ` Tejun Heo [this message]
[not found] ` <20110111174340.GD15933-Gd/HAXX7CRxy/B6EtB590w@public.gmane.org>
2011-01-11 18:33 ` Bart Van Assche
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110111174340.GD15933@htj.dyndns.org \
--to=tj-dgejt+ai2ygdnm+yrofe0a@public.gmane.org \
--cc=bvanassche-HInyCGIudOg@public.gmane.org \
--cc=dillowda-1Heg1YXhbW8@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=rdreier-FYB4Gu1CFyUAvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox