From: Jason Gunthorpe <jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
To: "J.L. Burr" <jlburr-vna1KIf7WgpBDgjK7y7TUQ@public.gmane.org>
Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: mlx4 fix for 36-bit bus addresses on 32-bit arch
Date: Thu, 13 Jan 2011 11:44:32 -0700 [thread overview]
Message-ID: <20110113184432.GA9681@obsidianresearch.com> (raw)
In-Reply-To: <4D2F310B.2010906-vna1KIf7WgpBDgjK7y7TUQ@public.gmane.org>
On Thu, Jan 13, 2011 at 12:06:19PM -0500, J.L. Burr wrote:
> However, I had a new concern about both the mthca and mlx4 changes so far:
> Are we sure using the phys_addr_t type is the correct thing to do?
I'd say this is right. It looks to me like the choice has been made to
just drop BAR's that have 64 bit addresses if the system is 32
bit.
Although, while looking into this I wonder J.L., how does your PCI
device even work? Look at, eg pci_read_bridge_mmio_ref, it seems to me
it will bail if a bridge is seen with a 64 bit setting but the system
isn't 64 bit? IMHO, this is a bug, it should be testing for
sizeof(resource_size_t)
Jason
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2011-01-13 18:44 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-07 2:59 [PATCH 1/1 (resend)] mthca: Modify to support embedded PowerPC platforms J.L. Burr
2011-01-07 5:59 ` Roland Dreier
2011-01-11 4:12 ` Roland Dreier
[not found] ` <adafwt06puj.fsf-FYB4Gu1CFyUAvxtiuMwx3w@public.gmane.org>
2011-01-12 8:00 ` J.L. Burr
[not found] ` <4D2D5FAD.6030508-vna1KIf7WgpBDgjK7y7TUQ@public.gmane.org>
2011-01-12 17:53 ` mlx4 fix for 36-bit bus addresses on 32-bit arch (was: [PATCH 1/1 (resend)] mthca: Modify to support embedded PowerPC platforms) Roland Dreier
[not found] ` <adahbde57r7.fsf_-_-FYB4Gu1CFyUAvxtiuMwx3w@public.gmane.org>
2011-01-13 17:06 ` mlx4 fix for 36-bit bus addresses on 32-bit arch J.L. Burr
[not found] ` <4D2F310B.2010906-vna1KIf7WgpBDgjK7y7TUQ@public.gmane.org>
2011-01-13 18:44 ` Jason Gunthorpe [this message]
[not found] ` <20110113184432.GA9681-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2011-01-13 22:10 ` Roland Dreier
[not found] ` <ada62ts316q.fsf-FYB4Gu1CFyUAvxtiuMwx3w@public.gmane.org>
2011-01-13 22:14 ` Jason Gunthorpe
[not found] ` <20110113221454.GB9681-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2011-01-14 12:46 ` J.L. Burr
2011-01-14 13:09 ` mlx4 fix for 36-bit bus addresses on 32-bit arch (was: [PATCH 1/1 (resend)] mthca: Modify to support embedded PowerPC platforms) Eli Cohen
2011-01-14 17:27 ` Jason Gunthorpe
[not found] ` <20110114172721.GB16535-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2011-01-14 21:26 ` mlx4 fix for 36-bit bus addresses on 32-bit arch Roland Dreier
[not found] ` <adawrm718ja.fsf-FYB4Gu1CFyUAvxtiuMwx3w@public.gmane.org>
2011-01-14 22:40 ` Jason Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110113184432.GA9681@obsidianresearch.com \
--to=jgunthorpe-epgobjl8dl3ta4ec/59zmfatqe2ktcn/@public.gmane.org \
--cc=jlburr-vna1KIf7WgpBDgjK7y7TUQ@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox