From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jason Gunthorpe Subject: Re: [PATCH 0/2] Improved node descriptions Date: Tue, 22 Feb 2011 22:41:52 -0700 Message-ID: <20110223054151.GA2363@obsidianresearch.com> References: <20110217213017.25708.95042.stgit@homer> <20110219192458.GB4506@obsidianresearch.com> <4C2744E8AD2982428C5BFE523DF8CDCB4A20B28B17@MNEXMB1.qlogic.org> <20110222234304.GA21731@obsidianresearch.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Roland Dreier Cc: Mike Heinz , "linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" List-Id: linux-rdma@vger.kernel.org On Tue, Feb 22, 2011 at 04:03:29PM -0800, Roland Dreier wrote: > On Tue, Feb 22, 2011 at 3:43 PM, Jason Gunthorpe > wrote: > > Doing it in userspace makes generating the node description changed > > trap simpler? > > Hmm... how many places can do sethostname()? Seems easier to > catch in the kernel than hook every place in userspace. (Although > there's no kernel hook right now) I do agree it would be good to > have some idea of how we could generate the "node desc changed" > trap at appropriate times. Wasn't thinking about 100% perfection, just if DHCP is the concern it shouldn't be hard to hook that one place. > > I just wonder if this is a big pain to do right, what about charsets, IDN, > > and ugly details like that? > > Does anyone expect to care about non-ASCII node descs? > What can we sensibly do except take what we're given? node desc is UTF-8, hostname is IDNA, a conversion is required, see RFC 3490. Does anyone care? Who knows, but very pedantically it is wrong to just copy the host name byte by byte. I only mention it to point out that it is trivial to do what Mike did, somewhat harder to do % escaping like you suggest and solve the multiple HCA problem, harder still to trap sethostname() and generate a trap, and extra special hard to correctly handle character sets on top of all that. :) So, is it still trivial to do it in the kernel? Jason -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html