From: Jason Gunthorpe <jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
To: Bart Van Assche <bvanassche-HInyCGIudOg@public.gmane.org>
Cc: Or Gerlitz <ogerlitz-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>,
Roland Dreier <roland-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
"linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [PATCH/libmlx] Set the ibv_wc.opcode even if the wc is an error wc
Date: Wed, 9 Mar 2011 10:42:37 -0700 [thread overview]
Message-ID: <20110309174237.GP22729@obsidianresearch.com> (raw)
In-Reply-To: <AANLkTinsu1xCJr0ROfjGABWg6yHZit27eSFPZgd7GFF2-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
On Wed, Mar 09, 2011 at 12:14:48PM +0100, Bart Van Assche wrote:
> If the mlx4 hardware can do this right now then that means that the
> mlx4 driver does not pass on the opcode for error completions.
Right, my patch fixes that for userspace, a kernel change would be
very similer, and it lookes like mtcha is basically the same too, if
the chip firwmare operate similarly.
The opcode that is passed on may not be 100% accurate, but it will
reflect the IBV_WC_RECV bit correctly.
> The approach taken in the recently posted ib_srpt code is to encode
> the opcode in the wr_id. See also the encode_wr_id(),
> opcode_from_wr_id() and idx_from_wr_id() functions.
Right, this is definitely required today.
Jason
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2011-03-09 17:42 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-09 4:26 [PATCH/libmlx] Set the ibv_wc.opcode even if the wc is an error wc Jason Gunthorpe
[not found] ` <20110309042613.GA21606-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2011-03-09 6:28 ` Or Gerlitz
[not found] ` <4D771E0F.7040402-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2011-03-09 7:04 ` Jason Gunthorpe
[not found] ` <20110309070441.GA25213-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2011-03-09 7:37 ` Or Gerlitz
[not found] ` <4D772E36.90103-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2011-03-09 11:31 ` Bart Van Assche
2011-03-09 17:40 ` Jason Gunthorpe
[not found] ` <20110309174044.GO22729-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2011-03-09 19:09 ` Bart Van Assche
2011-03-09 11:14 ` Bart Van Assche
[not found] ` <AANLkTinsu1xCJr0ROfjGABWg6yHZit27eSFPZgd7GFF2-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2011-03-09 17:42 ` Jason Gunthorpe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110309174237.GP22729@obsidianresearch.com \
--to=jgunthorpe-epgobjl8dl3ta4ec/59zmfatqe2ktcn/@public.gmane.org \
--cc=bvanassche-HInyCGIudOg@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=ogerlitz-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
--cc=roland-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox