From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jason Gunthorpe Subject: Re: [PATCH/opensm] Fix SANodeRecord.nodeInfo.localPortNum Date: Wed, 9 Mar 2011 11:51:18 -0700 Message-ID: <20110309185118.GD25229@obsidianresearch.com> References: <20110302002941.GA22729@obsidianresearch.com> <20110309154744.GV5577@calypso.voltaire.com> <20110309171126.GB15419@obsidianresearch.com> <20110309183441.GB25229@obsidianresearch.com> <20110309184022.GC25229@obsidianresearch.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Hal Rosenstock Cc: Alex Netes , linux-rdma List-Id: linux-rdma@vger.kernel.org On Wed, Mar 09, 2011 at 01:47:48PM -0500, Hal Rosenstock wrote: > On Wed, Mar 9, 2011 at 1:40 PM, Jason Gunthorpe > wrote: > > On Wed, Mar 09, 2011 at 01:38:27PM -0500, Hal Rosenstock wrote: > >> On Wed, Mar 9, 2011 at 1:34 PM, Jason Gunthorpe > >> wrote: > >> > On Wed, Mar 09, 2011 at 01:26:26PM -0500, Hal Rosenstock wrote: > >> > > >> >> > I don't think there is really any free interpretation here. For > >> >> > everything but a switch localPortNum must always reflect the port that > >> >> > portGUID is associated with. > >> >> > >> >> Unfortunately, this is not always true due to the funky cross (CA and > >> >> router) port PortInfo queries (but I don't think that query style is > >> >> used by OpenSM for CA or router ports but allowed in IBA)... > >> > > >> > What part of the spec are you referring to here? > >> > >> IBA 1.2.1 v1 p.830 line 9 the otherwise sentence. > > > > That is talking about PortInfo. NodeInfo does not support that > > attribute modifier language, my patch affects SANodeRecord. > > My bad :-( I was thinking of PortInfoRecord, not NodeRecord, for some reason... No worries, what do you think about my patch, does it align with what IBA intends? Thanks, Jason -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html