[PATCH] OpenSM torus routing order list

Alex Netes
2011-03-21T09:58:23Z

Enables to define list of switch ports so the SM will
go over this list when creating a routing.
It helps balancing links load on some communication patterns
where multipile links connect between the switches.

Signed-off-by: David McMillen <davem-klaOcWyJdxkshyMvu7JE4pqQE7yCjDx5@public.gmane.org>
Signed-off-by: Alex Netes <alexne-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
---
man/torus-2QoS.conf.5.in | 19 ++++++++++++-
opensm/osm_torus.c | 65 +++++++++++++++++++++++++++++++++++++++++++--
2 files changed, 79 insertions(+), 5 deletions(-)

diff --git a/man/torus-2QoS.conf.5.in b/man/torus-2QoS.conf.5.in
index 147a7b1..dd1aafb 100644
--- a/man/torus-2QoS.conf.5.in
+++ b/man/torus-2QoS.conf.5.in
@@ -62,7 +62,7 @@ see \fBUNICAST ROUTING\fR in torus-2QoS(8).
\fIsw0_GUID sw1_GUID
\fR
.RS
-These keywords are used to seed the torus/mesh topolgy.
+These keywords are used to seed the torus/mesh topology.
For example, "xp_link 0x2000 0x2001" specifies that a link from
the switch with node GUID 0x2000 to the switch with node GUID 0x2001
would point in the positive x direction,
@@ -78,7 +78,7 @@ for torus dimensions of radix four (see \fBTOPOLOGY DISCOVERY\fR in
torus-2QoS(8)). For such cases both the positive and negative coordinate
directions must be specified.
.P
-Based on the topology specifed via the \fBtorus\fR/\fBmesh\fR keyword,
+Based on the topology specified via the \fBtorus\fR/\fBmesh\fR keyword,
torus-2QoS will detect and log when it has insufficient seed configuration.
.RE
.
@@ -140,6 +140,17 @@ parameter needs to be increased.
If this keyword appears multiple times, the last instance prevails.
.RE
.
+.P
+\fBport_order
+\fIp1 p2 p3 ...
+\fR
+.RS
+This keyword specifies the order on which the ports would be chosen for routing.
+This keyword is optional and if given overrides the default order.
+It's possible to define any subset of ports that would be chosen before the
+others.
+.RE
+.
.SH EXAMPLE
.
\f(RC
@@ -171,6 +182,10 @@ z_dateline -1 # back to its original position.
# on a host attached to a switch from the second seed.
# Both instances should use this torus-2QoS.conf to ensure
# path SL values do not change in the event of SM failover.
+
+# port_order defines the order on which the ports would be
+# chosen for routing.
+port_order 7 10 8 11 9 12 25 28 26 29 27 30
.fi
\fR
.
diff --git a/opensm/osm_torus.c b/opensm/osm_torus.c
index add3cf9..7723a45 100644
--- a/opensm/osm_torus.c
+++ b/opensm/osm_torus.c
@@ -287,6 +287,8 @@ struct torus {
unsigned seed_cnt, seed_idx;
unsigned x_sz, y_sz, z_sz;

+ unsigned port_order[IB_NODE_NUM_PORTS_MAX+1];
+
unsigned sw_pool_sz;
unsigned link_pool_sz;
unsigned seed_sz;
@@ -844,6 +846,47 @@ out:
}

static
+bool parse_port(unsigned *pnum, const char *parse_sep)
+{
+ char *val, *nextchar;
+
+ val = strtok(NULL, parse_sep);
+ if (!val)
+ return false;
+ *pnum = strtoul(val, &nextchar, 0);
+ if (*pnum > IB_NODE_NUM_PORTS_MAX)
+ *pnum = 0;
+ return true;
+}
+
+static
+bool parse_port_order(struct torus *t, const char *parse_sep)
+{
+ unsigned i, j, k, n;
+
+ for (i = 0; i < (sizeof(t->port_order) / sizeof(unsigned)); i++) {
+ if (!parse_port(&(t->port_order[i]), parse_sep))
+ break;
+ for (j = 0; j < i; j++) {
+ if (t->port_order[j] == t->port_order[i]) {
+ i--; /* Ignore duplicate port number */
+ break;
+ }
+ }
+ }
+
+ n = i;
+ for (j = 0; j < (sizeof(t->port_order) / sizeof(unsigned)); j++) {
+ for (k = 0; k < i; k++)
+ if (t->port_order[k] == j)
+ break;
+ if (k >= i) t->port_order[n++] = j;
+ }
+
+ return true;
+}
+
+static
bool parse_pg_max_ports(struct torus *t, const char *parse_sep)
{
char *val, *nextchar;
@@ -1018,6 +1061,8 @@ next_line:
} else if (strcmp("mesh", keyword) == 0) {
t->flags |= X_MESH | Y_MESH | Z_MESH;
kw_success = parse_torus(t, parse_sep);
+ } else if (strcmp("port_order", keyword) == 0) {
+ kw_success = parse_port_order(t, parse_sep);
} else if (strcmp("next_seed", keyword) == 0) {
kw_success = grow_seed_array(t, 1);
t->seed_cnt++;
@@ -8424,6 +8469,7 @@ bool torus_lft(struct torus *t, struct t_switch *sw)
struct port_grp *pgrp;
struct t_switch *dsw;
osm_switch_t *osm_sw;
+ unsigned order[IB_NODE_NUM_PORTS_MAX+1];

if (!(sw->osm_switch && sw->osm_switch->priv == sw)) {
OSM_LOG(&t->osm->log, OSM_LOG_ERROR,
@@ -8439,13 +8485,22 @@ bool torus_lft(struct torus *t, struct t_switch *sw)
dsw = t->sw_pool[s];
pgrp = &dsw->ptgrp[2 * TORUS_MAX_DIM];

- for (p = 0; p < pgrp->port_cnt; p++) {
+ memset(order, IB_INVALID_PORT_NUM, sizeof(order));
+ for (p = 0; p < pgrp->port_cnt; p++)
+ order[pgrp->port[p]->port] = p;
+
+ for (p = 0; p < IB_NODE_NUM_PORTS_MAX; p++) {
+
+ unsigned px = order[t->port_order[p]];

- if (!get_lid(pgrp, p, &dlid_base, &dlid_lmc, &ca))
+ if (px >= pgrp->port_cnt)
+ continue;
+
+ if (!get_lid(pgrp, px, &dlid_base, &dlid_lmc, &ca))
return false;

if (sw->n_id == dsw->n_id)
- dp = pgrp->port[p]->port;
+ dp = pgrp->port[px]->port;
else
dp = lft_port(t, sw, dsw, true, ca);
/*
@@ -9128,6 +9183,7 @@ int torus_build_lfts(void *context)
struct torus_context *ctx = context;
struct fabric *fabric;
struct torus *torus;
+ unsigned i;

if (!ctx->osm->subn.opt.qos) {
OSM_LOG(&ctx->osm->log, OSM_LOG_ERROR,
@@ -9149,6 +9205,9 @@ int torus_build_lfts(void *context)
torus->osm = ctx->osm;
fabric->osm = ctx->osm;

+ for (i = 0; i < (sizeof(torus->port_order) / sizeof(unsigned)); i++)
+ torus->port_order[i] = i;
+
if (!parse_config(ctx->osm->subn.opt.torus_conf_file,
fabric, torus))
goto out;
--
1.7.3.4