Re: [PATCH] ib: mlx4 map fix for large hugetlb areas

[Eli Cohen <eli-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>]

On Mon, Jun 06, 2011 at 09:09:42AM -0700, Roland Dreier wrote:
> On Mon, Jun 6, 2011 at 4:29 AM, Dan aloni <alonid-IGuEOkGjbyfby3iVrkZq2A@public.gmane.org> wrote:
> > --- a/drivers/infiniband/hw/mlx4/mr.c
> > +++ b/drivers/infiniband/hw/mlx4/mr.c
> > @@ -140,7 +140,7 @@ static int handle_hugetlb_user_mr(struct ib_pd *pd, struct mlx4_ib_mr *mr,
> >        int off = start & (HPAGE_SIZE - 1);
> >
> >        n = DIV_ROUND_UP(off + umem->length, HPAGE_SIZE);
> > -       arr = kmalloc(n * sizeof *arr, GFP_KERNEL);
> > +       arr = vmalloc(n * sizeof *arr);
> >        if (!arr)
> >                return -ENOMEM;
> >
> 
> I'm not able to find anywhere in the mlx4 driver where this patch
> would have a chance at applying??
> 

I submitted this patch about 2 years ago. As far as I recall there was
a problem to obtain the huge page size for powerpc archs and that's
were the patch died. We're are using it in OFED for x86_64 and it
gives significant improvement when registering huge pages. I will
re-submit an up to date version.
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html