From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ira Weiny Subject: Re: [PATCH] infiniband-diags/libibnetdisc/ibnetdisc.c: Fix possible overrun of path Date: Fri, 10 Jun 2011 11:43:15 -0700 Message-ID: <20110610114315.6730e820.weiny2@llnl.gov> References: <4DEF6F53.4060304@dev.mellanox.co.il> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <4DEF6F53.4060304-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org> Sender: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Hal Rosenstock Cc: "linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" List-Id: linux-rdma@vger.kernel.org On Wed, 8 Jun 2011 05:47:15 -0700 Hal Rosenstock wrote: > > when path->cnt is 63 in add_port_to_dpath > > Signed-off-by: Hal Rosenstock Thanks applied, Ira > --- > diff --git a/libibnetdisc/src/ibnetdisc.c b/libibnetdisc/src/ibnetdisc.c > index 7ba87fd..4a4f33b 100644 > --- a/libibnetdisc/src/ibnetdisc.c > +++ b/libibnetdisc/src/ibnetdisc.c > @@ -80,7 +80,7 @@ static int query_switch_info(smp_engine_t * engine, ib_portid_t * portid, > > static int add_port_to_dpath(ib_dr_path_t * path, int nextport) > { > - if (path->cnt > sizeof(path->p) - 1) > + if (path->cnt > sizeof(path->p) - 2) > return -1; > ++path->cnt; > path->p[path->cnt] = (uint8_t) nextport; -- Ira Weiny Math Programmer/Computer Scientist Lawrence Livermore National Lab 925-423-8008 weiny2-i2BcT+NCU+M@public.gmane.org -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html