Re: [PATCH 2/2] libibverbs: Add support for XRC QPs

[Dotan Barak <dotan-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>]

Hi.
I noticed minor issue:

> @@ -564,6 +597,16 @@ struct ibv_srq {
>  	pthread_mutex_t		mutex;
>  	pthread_cond_t		cond;
>  	uint32_t		events_completed;
> +
> +	/* Following fields only available if device supports extensions */
> +	enum ibv_srq_type	srq_type;
> +	union {
> +		struct {
> +			uint32_t	 srq_num;
> +			struct ibv_xrcd *xrcd;
> +			struct ibv_cq   *cq;
> +		} xrc;
> +	} ext;
>  };

Should the following struct be used instead of the suggested struct above? 

	struct {
		struct ibv_xrcd *xrcd;
		struct ibv_cq   *cq;
		uint32_t	 srq_num;
	} xrc;

(attributes were rearranged according to their size).


Thanks
Dotan
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html