Re: [PATCH] opensm: enable perfmgr build by default

Ira Weiny
2011-07-08T16:06:58Z

On Fri, 8 Jul 2011 03:49:27 -0700
Alex Netes <alexne-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org> wrote:

> Hi Ira,
>
> On 15:11 Wed 06 Jul , Ira Weiny wrote:
> > This should at least be compiled in by default.
> >
> >
> > Signed-off-by: Ira Weiny <weiny2-i2BcT+NCU+M@public.gmane.org>
> > ---
>
> Sounds like a good idea.
> If we change the defaults, why should we keep this option for configure
> script? Is it really needed?

For our needs, no. However, when we first put the PerfMgr in OpenSM there was some concern for developers who may be using OpenSM in an embedded environment. Since the option exists (less work for me!) I did not see a good reason to take it out so that those developers could still compile it out if they wanted. If this is no longer a requirement then, yes, I can remove the configure option.

Does anyone else want to chime in here?

> What about performance manager profiling? Shout it also compiled by default?

I think this may affect performance. Although I don't think by much. Since it is more of a development/debugging tool rather than something I think the user would want I thought it should still be a compile option. If we do compile it on by default I would put an option in opensm.conf.

Let me know and I can alter the patch as you wish,
Ira

>
> -- Alex

--
Ira Weiny
Math Programmer/Computer Scientist
Lawrence Livermore National Lab
925-423-8008
weiny2-i2BcT+NCU+M@public.gmane.org