Re: [PATCH] opensm: Add support for PID file

[Jason Gunthorpe <jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>]

On Wed, Jul 13, 2011 at 11:26:40AM +0300, Alex Netes wrote:
> @@ -407,6 +408,10 @@ This option defines the file name for the extra configuration
>  information needed for the torus-2QoS routing engine.   The default
>  name is \fB\%@OPENSM_CONFIG_DIR@/@TORUS2QOS_CONF_FILE@\fP
>  .TP
> +\fB\-\-pid_file\fR <path to pid file>
> +Specifies the file that contains the process ID of the opensm daemon.
> +The default is \fB/var/run/opensm.pid\fP
> +.TP

Should use a configure substitution for /var/run/opensm.pid here..

> +	printf("--pid_file <path to file>\n"
> +	       "          Specifies the file that contains the process ID of the\n"
> +	       "          opensm daemon.The default is /var/run/opensm.pid\n");

And this should be OSM_DEFAULT_PID_FILE

> +	if (opt.daemon) {
> +		FILE *f = fopen(opt.pid_file, "w");

Need a "wt" in case the file already exists

Jason
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html