From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jack Morgenstein Subject: Re: [PATCH] rdma_cm: avoid assigning an IS_ERR value to cm id pointer in CMA id object Date: Tue, 19 Jul 2011 09:45:43 +0300 Message-ID: <201107190945.44326.jackm@dev.mellanox.co.il> References: <201107141058.29879.jackm@dev.mellanox.co.il> <1828884A29C6694DAF28B7E6B8A8237302E6B9@ORSMSX101.amr.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: In-Reply-To: Content-Disposition: inline Sender: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Roland Dreier Cc: "Hefty, Sean" , "linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "dotanb-VPRAkNaXOzVS1MOuV/RT9w@public.gmane.org" List-Id: linux-rdma@vger.kernel.org On Monday 18 July 2011 19:39, Roland Dreier wrote: > On Mon, Jul 18, 2011 at 9:35 AM, Hefty, Sean w= rote: > >> - =A0 =A0 if (ret && !IS_ERR(id_priv->cm_id.ib)) { > >> + =A0 =A0 if (ret && !IS_ERR(id)) { > >> =A0 =A0 =A0 =A0 =A0 =A0 =A0 ib_destroy_cm_id(id_priv->cm_id.ib); > > > > I would change the above line to ib_destroy_cm_id(id) to align the = destroy call with the if statement. >=20 > OK, I'll grab this and make that suggested change as I merge it... no > need to resend. >=20 > - R. Thanks, Roland! -Jack -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" i= n the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html