From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jason Gunthorpe Subject: Re: [PATCH 1/7] libibverbs: Add link layer field port attribute Date: Tue, 19 Jul 2011 11:04:54 -0600 Message-ID: <20110719170454.GD18090@obsidianresearch.com> References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Or Gerlitz Cc: Roland Dreier , linux-rdma List-Id: linux-rdma@vger.kernel.org On Tue, Jul 19, 2011 at 12:27:17PM +0300, Or Gerlitz wrote: > The addition of the new field does not change the size of struct > ibv_port_attr due to alignment of the preceding fields. As such > binary compatibility between the library to applications is kept, What zeros the field in the current library? It looks like new apps that want to access the link_layer field will have to explicitly zero port_attr before calling ibv_cmd_query_port. Should be noted in the documentation - and maybe also explicitly zero the remaining pad for future. Jason -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html