From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jason Gunthorpe Subject: Re: [PATCH 1/7] libibverbs: Add link layer field port attribute Date: Tue, 19 Jul 2011 13:50:20 -0600 Message-ID: <20110719195020.GE18090@obsidianresearch.com> References: <20110719170454.GD18090@obsidianresearch.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Or Gerlitz Cc: Or Gerlitz , Roland Dreier , linux-rdma List-Id: linux-rdma@vger.kernel.org On Tue, Jul 19, 2011 at 10:36:26PM +0300, Or Gerlitz wrote: > > What zeros the field in the current library? > > the kernel uverbs code either zeros it (old kernels) or sets it (new kernels) ibv_cmd_query_port does a field by field copy of the port_attr, so what the kernel does is not relevant to this case, and to me it looks like the new value you added will be left uninitialized on old ibverbs. Jason -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html