From: Alex Netes <alexne-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
To: Rolf Manderscheid
<rvm-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH] ibsim: fix size of slid/dlid fields in sim_request structure
Date: Tue, 9 Aug 2011 18:07:23 +0300 [thread overview]
Message-ID: <20110809150723.GC2056@calypso.mtl.com> (raw)
In-Reply-To: <E1QpTpl-00026F-D6-nLM+XIojDeH72zTlGHhC+rDks+cytr/Z@public.gmane.org>
Hi Rolf,
On 17:29 Fri 05 Aug , Rolf Manderscheid wrote:
>
> The code treats them as 16-bit fields (by using htons), make
> the structure match. This also avoids the 32 bits of padding
> before the length field.
>
There are more places where lids defined as integer. Why did you choose to
change only these two?
> Signed-off-by: Rolf Manderscheid <rvm-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
> ---
> include/ibsim.h | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/include/ibsim.h b/include/ibsim.h
> index 15fc37c..b6b08bd 100644
> --- a/include/ibsim.h
> +++ b/include/ibsim.h
> @@ -62,8 +62,8 @@ struct sim_port {
> #define SIM_CTL_MAX_DATA 64
>
> struct sim_request {
> - uint32_t dlid;
> - uint32_t slid;
> + uint16_t dlid;
> + uint16_t slid;
> uint32_t dqp;
> uint32_t sqp;
> uint32_t status;
> --
> 1.7.1
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
> the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
-- Alex
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2011-08-09 15:07 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-05 23:29 [PATCH] ibsim: fix size of slid/dlid fields in sim_request structure Rolf Manderscheid
[not found] ` <E1QpTpl-00026F-D6-nLM+XIojDeH72zTlGHhC+rDks+cytr/Z@public.gmane.org>
2011-08-09 15:07 ` Alex Netes [this message]
[not found] ` <20110809150723.GC2056-iQai9MGU/dze+A/uUDamNg@public.gmane.org>
2011-08-10 17:18 ` Rolf Manderscheid
[not found] ` <4E42BD69.6070608-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2011-08-10 19:37 ` Jason Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110809150723.GC2056@calypso.mtl.com \
--to=alexne-vpraknaxozvwk0htik3j/w@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=rvm-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox