From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alex Netes Subject: Re: [PATCH] ibsim: fix size of slid/dlid fields in sim_request structure Date: Tue, 9 Aug 2011 18:07:23 +0300 Message-ID: <20110809150723.GC2056@calypso.mtl.com> References: Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Rolf Manderscheid Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-rdma@vger.kernel.org Hi Rolf, On 17:29 Fri 05 Aug , Rolf Manderscheid wrote: > > The code treats them as 16-bit fields (by using htons), make > the structure match. This also avoids the 32 bits of padding > before the length field. > There are more places where lids defined as integer. Why did you choose to change only these two? > Signed-off-by: Rolf Manderscheid > --- > include/ibsim.h | 4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/include/ibsim.h b/include/ibsim.h > index 15fc37c..b6b08bd 100644 > --- a/include/ibsim.h > +++ b/include/ibsim.h > @@ -62,8 +62,8 @@ struct sim_port { > #define SIM_CTL_MAX_DATA 64 > > struct sim_request { > - uint32_t dlid; > - uint32_t slid; > + uint16_t dlid; > + uint16_t slid; > uint32_t dqp; > uint32_t sqp; > uint32_t status; > -- > 1.7.1 > > > -- > To unsubscribe from this list: send the line "unsubscribe linux-rdma" in > the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- -- Alex -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html