Re: [PATCH] ibsim: fix size of slid/dlid fields in sim_request structure

[Jason Gunthorpe <jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>]

On Wed, Aug 10, 2011 at 11:18:33AM -0600, Rolf Manderscheid wrote:
> Hi Alex,
> >There are more places where lids defined as integer. Why did you choose to
> >change only these two?
> 
> This structure defines what request packets look like on the wire to
> the simulator.  The motivation for the change is a simulator client
> for python-rdma, and this issue shows up when creating the structure
> format strings for the request packets.

Also that

uint32_t x = htons(y)

Simply doesn't work when you mix big and little endian. So, the
choices are: switch the type to uint16, or switch to htonl. This is the
reason only this struct was changed - because it is the only place
where htons is being applied incorrectly, while finding all the wrong
htons is a bit harder.

python cares because it cannot easily construct something so malformed :)

Jason
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html