From: Ira Weiny <weiny2-i2BcT+NCU+M@public.gmane.org>
To: Hal Rosenstock <hal-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>
Cc: "linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
Daniel Klein <danielk-VPRAkNaXOzVS1MOuV/RT9w@public.gmane.org>
Subject: Re: [PATCHv2] infiniband-diags/ibnetdiscover.c: Fix cap_mask endian for extended link speeds
Date: Wed, 31 Aug 2011 16:45:39 -0700 [thread overview]
Message-ID: <20110831164539.6b090e10.weiny2@llnl.gov> (raw)
In-Reply-To: <4E5C0227.10901-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>
On Mon, 29 Aug 2011 14:18:31 -0700
Hal Rosenstock <hal-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org> wrote:
>
> Signed-off-by: Daniel Klein <danielk-VPRAkNaXOzVS1MOuV/RT9w@public.gmane.org>
> Signed-off-by: Hal Rosenstock <hal-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
thanks applied,
Ira
> ---
> Changes since v1:
> Cosmetic formatting changes
>
> diff --git a/src/ibnetdiscover.c b/src/ibnetdiscover.c
> index 0966217..09bd1c1 100644
> --- a/src/ibnetdiscover.c
> +++ b/src/ibnetdiscover.c
> @@ -375,7 +375,7 @@ void out_switch_port(ibnd_port_t * port, int group, char *out_prefix)
> ext_port_str = out_ext_port(port->remoteport, group);
> cap_mask = mad_get_field(port->node->ports[0]->info, 0,
> IB_PORT_CAPMASK_F);
> - if (cap_mask & IB_PORT_CAP_HAS_EXT_SPEEDS)
> + if (cap_mask & CL_NTOH32(IB_PORT_CAP_HAS_EXT_SPEEDS))
> espeed = mad_get_field(port->info, 0,
> IB_PORT_LINK_SPEED_EXT_ACTIVE_F);
> else
> @@ -433,7 +433,7 @@ void out_ca_port(ibnd_port_t * port, int group, char *out_prefix)
> port->remoteport->node->nodedesc);
>
> cap_mask = mad_get_field(port->info, 0, IB_PORT_CAPMASK_F);
> - if (cap_mask & IB_PORT_CAP_HAS_EXT_SPEEDS)
> + if (cap_mask & CL_NTOH32(IB_PORT_CAP_HAS_EXT_SPEEDS))
> espeed = mad_get_field(port->info, 0,
> IB_PORT_LINK_SPEED_EXT_ACTIVE_F);
> else
> @@ -684,7 +684,7 @@ void dump_ports_report(ibnd_node_t * node, void *user_data)
> else
> info = (uint8_t *)&port->info;
> cap_mask = mad_get_field(info, 0, IB_PORT_CAPMASK_F);
> - if (cap_mask & IB_PORT_CAP_HAS_EXT_SPEEDS)
> + if (cap_mask & CL_NTOH32(IB_PORT_CAP_HAS_EXT_SPEEDS))
> espeed = mad_get_field(port->info, 0,
> IB_PORT_LINK_SPEED_EXT_ACTIVE_F);
> else
--
Ira Weiny
Math Programmer/Computer Scientist
Lawrence Livermore National Lab
925-423-8008
weiny2-i2BcT+NCU+M@public.gmane.org
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2011-08-31 23:45 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-29 21:18 [PATCHv2] infiniband-diags/ibnetdiscover.c: Fix cap_mask endian for extended link speeds Hal Rosenstock
[not found] ` <4E5C0227.10901-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>
2011-08-31 23:45 ` Ira Weiny [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110831164539.6b090e10.weiny2@llnl.gov \
--to=weiny2-i2bct+ncu+m@public.gmane.org \
--cc=danielk-VPRAkNaXOzVS1MOuV/RT9w@public.gmane.org \
--cc=hal-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox