Re: [PATCH/ibsim] Provide support for SubnSet(GUIDInfo)

Hal Rosenstock
2011-09-19T19:55:24Z

On Mon, Sep 19, 2011 at 11:59 AM, Jason Gunthorpe
<jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org> wrote:
> On Mon, Sep 19, 2011 at 10:07:57AM -0400, Hal Rosenstock wrote:
>> On Fri, Sep 16, 2011 at 5:06 PM, Jason Gunthorpe
>> <jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org> wrote:
>> > Hardwire PortInfo.GUIDCap to 1 for both the switch and HCA case,
>>
>> Why hardwire this to 1 ? This is not what most defaults are.
>>
>> > then simply verify that the incoming SubnSet matches the RO data
>> > in block 0.
>>
>> Is this just to make the set of guidinfo simple ? Longer term, this
>> should support a GUIDCap > 1 but I suppose that could be a follow on
>> patch to this.
>
> It is to make the existing ibsim compliant with the spec.

Yes, supporting set of guidinfo is compliant but I think your
treatment of guid 0 in block 0 is overzealous and non compliant.

-- Hal

> If someone
> cares about simulating guidinfo then they can implement a higher port
> cap, otherwise, setting it to one lets things that those do try to
> manipulate guid info not blow up.

> Jason