From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jason Gunthorpe Subject: Re: [PATCH/ibsim] Provide support for SubnSet(GUIDInfo) Date: Mon, 19 Sep 2011 14:06:37 -0600 Message-ID: <20110919200637.GA28454@obsidianresearch.com> References: <20110916210611.GA6926@obsidianresearch.com> <20110919155904.GA8113@obsidianresearch.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Hal Rosenstock Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Alex Netes List-Id: linux-rdma@vger.kernel.org On Mon, Sep 19, 2011 at 03:55:24PM -0400, Hal Rosenstock wrote: > >> Is this just to make the set of guidinfo simple ? Longer term, this > >> should support a GUIDCap > 1 but I suppose that could be a follow on > >> patch to this. > > > > It is to make the existing ibsim compliant with the spec. > > Yes, supporting set of guidinfo is compliant but I think your > treatment of guid 0 in block 0 is overzealous and non compliant. Having sim return an error if an invalid RO field is written is useful from a testing prespective, since nothing should do a set without the correct entry 0 GUID. A strict reading of the spec would say that no GUIDInfo set is invalid, even if it tries to set non-zero values for entries past the GUIDCap. I don't see how that is useful behavior for ibsim. Jason -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html