Re: [PATCH/ibsim] Provide support for SubnSet(GUIDInfo)

Hal Rosenstock
2011-09-21T13:04:45Z

On Mon, Sep 19, 2011 at 4:06 PM, Jason Gunthorpe
<jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org> wrote:
> On Mon, Sep 19, 2011 at 03:55:24PM -0400, Hal Rosenstock wrote:
>
>> >> Is this just to make the set of guidinfo simple ? Longer term, this
>> >> should support a GUIDCap > 1 but I suppose that could be a follow on
>> >> patch to this.
>> >
>> > It is to make the existing ibsim compliant with the spec.

You wrote that this was for spec compliance...

>> Yes, supporting set of guidinfo is compliant but I think your
>> treatment of guid 0 in block 0 is overzealous and non compliant.
>
> Having sim return an error if an invalid RO field is written
> is useful from a testing prespective, since nothing should do a set
> without the correct entry 0 GUID.

A correct block 0 entry 0 entry makes no difference on set. The get
response will have the correct value in that entry though regardless
of the value in the set request.

> A strict reading of the spec would say that no GUIDInfo set is
> invalid, even if it tries to set non-zero values for entries past the
> GUIDCap. I don't see how that is useful behavior for ibsim.

A compliant SMA would not have a problem with either of these things.
It wouldn't look at the read only block 0 entry 0 nor at any guids in
a valid block above the guid cap.

-- Hal

> Jason