From: Jason Gunthorpe <jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
To: Hal Rosenstock <hal.rosenstock-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: "Hefty,
Sean" <sean.hefty-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
Marcel Apfelbaum
<marcela-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>,
"roland-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org"
<roland-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
"linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [PATCH RFC 1/4] ib/core: handle EDR/FDR extended speeds
Date: Mon, 19 Sep 2011 14:14:13 -0600 [thread overview]
Message-ID: <20110919201413.GB28454@obsidianresearch.com> (raw)
In-Reply-To: <CAKzyTsxxuB=k+N+rxPmfx8zZZApDdr-_FfajDstDVa7M1nV8xg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
On Mon, Sep 19, 2011 at 02:26:13PM -0400, Hal Rosenstock wrote:
> Right.
>
> > Why carry that same concept into a software interface? ??It seems complex.
>
> So as not to break existing verbs apps by inventing new values to
> existing fields which wouldn't be understood.
Every app I've ever worked with that needs this information uses one
function to map the speed to whatever it needs, sprinkling the
information that function needs all over the place will only make it
harder to update the app.
If we are going to change the structure can we at least introduce
something sane, like a 'uint64_t link_rate_in_bps' so we don't have
this problem again?
Jason
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2011-09-19 20:14 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-19 16:06 [PATCH RFC 1/4] ib/core: handle EDR/FDR extended speeds Marcel Apfelbaum
[not found] ` <201109191906.05360.marcela-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>
2011-09-19 18:00 ` Hefty, Sean
[not found] ` <1828884A29C6694DAF28B7E6B8A8237316E64FDC-P5GAC/sN6hmkrb+BlOpmy7fspsVTdybXVpNB7YpNyf8@public.gmane.org>
2011-09-19 18:11 ` Hal Rosenstock
[not found] ` <CAKzyTszd0LSOaY4RFCw2WpNBBQcgfkUYFSOy6q+rC1SjSb4q3A-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2011-09-19 18:17 ` Hefty, Sean
[not found] ` <1828884A29C6694DAF28B7E6B8A8237316E6508C-P5GAC/sN6hmkrb+BlOpmy7fspsVTdybXVpNB7YpNyf8@public.gmane.org>
2011-09-19 18:26 ` Hal Rosenstock
[not found] ` <CAKzyTsxxuB=k+N+rxPmfx8zZZApDdr-_FfajDstDVa7M1nV8xg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2011-09-19 18:32 ` Or Gerlitz
2011-09-19 20:14 ` Jason Gunthorpe [this message]
[not found] <CAN+0-cYdBs_FyX-1+Z54qDvOUdQoz+MqFaW4QETN0ubhGA=DMA@mail.gmail.com>
[not found] ` <CAN+0-cYdBs_FyX-1+Z54qDvOUdQoz+MqFaW4QETN0ubhGA=DMA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2011-09-19 15:02 ` Marcel Apfelbaum
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110919201413.GB28454@obsidianresearch.com \
--to=jgunthorpe-epgobjl8dl3ta4ec/59zmfatqe2ktcn/@public.gmane.org \
--cc=hal.rosenstock-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=marcela-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org \
--cc=roland-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=sean.hefty-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox