public inbox for linux-rdma@vger.kernel.org
 help / color / mirror / Atom feed
From: Alex Netes <alexne-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
To: "Hefty, Sean" <sean.hefty-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Cc: Bart Van Assche <bvanassche-HInyCGIudOg@public.gmane.org>,
	"linux-rdma
	(linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org)"
	<linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	"Hal Rosenstock
	(hal.rosenstock-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org)"
	<hal.rosenstock-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
	"ofw-ZwoEplunGu1OwGhvXhtEPSCwEArCW2h5@public.gmane.org"
	<ofw-ZwoEplunGu1OwGhvXhtEPSCwEArCW2h5@public.gmane.org>
Subject: Re: creating common ib_types.h for linux and windows
Date: Wed, 21 Sep 2011 16:29:45 +0300	[thread overview]
Message-ID: <20110921132945.GA3767@calypso.mtl.com> (raw)
In-Reply-To: <1828884A29C6694DAF28B7E6B8A8237316E6526F-P5GAC/sN6hmkrb+BlOpmy7fspsVTdybXVpNB7YpNyf8@public.gmane.org>

On 14:23 Tue 20 Sep     , Hefty, Sean wrote:
> > Why to test for __WIN__ instead of _WIN32 (defined both when building
> > 32-bit and 64-bit code -- see also
> > http://msdn.microsoft.com/en-us/library/b0084kay%28v=vs.80%29.aspx) ?
> 
> I have no idea.  This is just what's currently in the code.  I can change this portion of the code if we want to use #ifdef's.
> 

Digging into the history, I found this patch that added __WIN__ defined for
Windows: http://www.spinics.net/lists/linux-rdma/msg00451.html

> > When creating a common header file, this might be a good start:
> > https://msinttypes.googlecode.com/svn/trunk/stdint.h
> 
> There are already shared types defined between linux and windows that opensm uses.  For the most part, there's no technical reason why windows can't use 99% of the linux ib_types.h as is.  My goal is to be able to take the file and drop it into the windows build tree without needing changes.

What is your end goal? To have one code base for OpenSM that would be able to
be compiled on both Linux and Windows based on __WIN__ definition?

> 
> Btw, as background I tried to pull in the latest ibmad and ibdiags into windows.  The build broke because of new defines that had been added to ib_types.h.  Eventually we should be able to drop opensm directly into the windows build as well.
> 
> - Sean
> --
> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
> the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

-- 

-- Alex
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  parent reply	other threads:[~2011-09-21 13:29 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-09-19 21:20 creating common ib_types.h for linux and windows Hefty, Sean
     [not found] ` <1828884A29C6694DAF28B7E6B8A8237316E65191-P5GAC/sN6hmkrb+BlOpmy7fspsVTdybXVpNB7YpNyf8@public.gmane.org>
2011-09-20  6:06   ` Bart Van Assche
     [not found]     ` <CAO+b5-p0O5N6ZZacYGNjz4+H=W3hX6O7kw5pO=XqXSdh3FEdhA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2011-09-20 14:23       ` Hefty, Sean
     [not found]         ` <1828884A29C6694DAF28B7E6B8A8237316E6526F-P5GAC/sN6hmkrb+BlOpmy7fspsVTdybXVpNB7YpNyf8@public.gmane.org>
2011-09-21 13:29           ` Alex Netes [this message]
     [not found]             ` <20110921132945.GA3767-iQai9MGU/dze+A/uUDamNg@public.gmane.org>
2011-09-21 14:15               ` Smith, Stan
2011-09-21 15:49               ` Hefty, Sean
     [not found]                 ` <1828884A29C6694DAF28B7E6B8A8237316E66732-P5GAC/sN6hmkrb+BlOpmy7fspsVTdybXVpNB7YpNyf8@public.gmane.org>
2011-09-25 10:39                   ` Alex Netes

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110921132945.GA3767@calypso.mtl.com \
    --to=alexne-vpraknaxozvwk0htik3j/w@public.gmane.org \
    --cc=bvanassche-HInyCGIudOg@public.gmane.org \
    --cc=hal.rosenstock-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    --cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=ofw-ZwoEplunGu1OwGhvXhtEPSCwEArCW2h5@public.gmane.org \
    --cc=sean.hefty-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox