From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jason Gunthorpe Subject: Re: [PATCH] ib-diags: Add cast to fix build on windows Date: Thu, 22 Sep 2011 17:32:46 -0600 Message-ID: <20110922233246.GL28454@obsidianresearch.com> References: <1828884A29C6694DAF28B7E6B8A8237316E674F0@ORSMSX101.amr.corp.intel.com> <1828884A29C6694DAF28B7E6B8A8237316E67532@ORSMSX101.amr.corp.intel.com> <20110922212756.GJ28454@obsidianresearch.com> <1828884A29C6694DAF28B7E6B8A8237316E675B2@ORSMSX101.amr.corp.intel.com> <20110922213907.GK28454@obsidianresearch.com> <1828884A29C6694DAF28B7E6B8A8237316E675EB@ORSMSX101.amr.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <1828884A29C6694DAF28B7E6B8A8237316E675EB-P5GAC/sN6hmkrb+BlOpmy7fspsVTdybXVpNB7YpNyf8@public.gmane.org> Sender: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: "Hefty, Sean" Cc: Bart Van Assche , "linux-rdma (linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org)" , "Ira Weiny (weiny2-i2BcT+NCU+M@public.gmane.org)" List-Id: linux-rdma@vger.kernel.org On Thu, Sep 22, 2011 at 11:03:24PM +0000, Hefty, Sean wrote: > > It supresses a warning, warnings are not build failures. > > Actually, on windows the build fails. No executables are built. Seriously? I hope this is because you've got the warnings are errors flag set.. > mad_[get|set]_field[8|16|32] should work fine. But those are > exported from ibmad, which would require ib-diags to either check > for them as a requirement or implement them if not found. Everyone using ibmad on windows should have this problem, so fixing ibmad seems proper to me.. Tag the no-size ones with deprecated and you will no longer have this problem in your Windows porting efforts because all the Linux compilers will complain. Jason -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html