* [PATCH] rdma/cma: minor code refactoring when saving a string content
@ 2011-10-30 11:48 Dotan Barak
[not found] ` <201110301348.05062.dotanb-g2bIKuvJtcQanlnWow0HJg@public.gmane.org>
0 siblings, 1 reply; 2+ messages in thread
From: Dotan Barak @ 2011-10-30 11:48 UTC (permalink / raw)
To: Sean Hefty; +Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA
In this case, using strdup will provide a cleaner code
(and maybe a little bit faster too).
Signed-off-by: Dotan Barak <dotanb-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>
---
src/addrinfo.c | 4 +---
1 files changed, 1 insertions(+), 3 deletions(-)
diff --git a/src/addrinfo.c b/src/addrinfo.c
index 695430b..34c7fb4 100755
--- a/src/addrinfo.c
+++ b/src/addrinfo.c
@@ -137,9 +137,7 @@ static int ucma_convert_to_rai(struct rdma_addrinfo *rai,
if (!addr)
return ERR(ENOMEM);
- canonname = ai->ai_canonname ? malloc(strlen(ai->ai_canonname) + 1) : NULL;
- if (canonname)
- strcpy(canonname, ai->ai_canonname);
+ canonname = ai->ai_canonname ? strdup(ai->ai_canonname) : NULL;
memcpy(addr, ai->ai_addr, ai->ai_addrlen);
if (ai->ai_flags & RAI_PASSIVE) {
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related [flat|nested] 2+ messages in thread
* RE: [PATCH] rdma/cma: minor code refactoring when saving a string content
[not found] ` <201110301348.05062.dotanb-g2bIKuvJtcQanlnWow0HJg@public.gmane.org>
@ 2011-10-31 15:56 ` Hefty, Sean
0 siblings, 0 replies; 2+ messages in thread
From: Hefty, Sean @ 2011-10-31 15:56 UTC (permalink / raw)
To: Dotan Barak; +Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
thanks - applied
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-10-31 15:56 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-10-30 11:48 [PATCH] rdma/cma: minor code refactoring when saving a string content Dotan Barak
[not found] ` <201110301348.05062.dotanb-g2bIKuvJtcQanlnWow0HJg@public.gmane.org>
2011-10-31 15:56 ` Hefty, Sean
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox