Re: [PATCH 00/11] New Caching mechanism for ib_core

Goldwyn Rodrigues
2011-11-09T12:19:08Z

Thanks Sean for the review.

On Tue, Nov 08, 2011 at 11:46:50PM +0000, Hefty, Sean wrote:
> > The main motivations are:
> >
> > 1. Greater degree of control by individual drivers. Drivers have a
> > choice to use it or not.
>
> I believe that some callers need to know that specific query calls will not sleep. That capability should either be required or exposed through the API.

The new cache access functions do not sleep. This is the primary
objective of the exercise. See motviation 2 :)
Exceptions are the init functions which may sleep because of kzalloc().
Did you want me to mention this specifically in the comments?

>
> > 2. The library functions do not sleep, and can be called from any context.
> >
> > In the bargain we lose the lmc cache. However, if we move it to the device
> > structure like the pkey_tbl_len, it can be accessed directly (TODO).
> > Let me know what you think about it.
>
> The LMC cache is accessed by the MAD layer. I know that MADs aren't considered a performance path, but we don't want to query the device for every MAD.
>

I understand. I will try to incorporate the lmc cache in the device
structure while I wait for the rest of the comments.

Regards,