[opensm] [PATCH 1/2] Fix segfault corner case

[opensm] [PATCH 1/2] Fix segfault corner case

[Albert Chu]

On rescan, data segment memory could be attempted to be freed by
config file parsing code.

Signed-off-by: Albert L. Chu <chu11-i2BcT+NCU+M@public.gmane.org>
---
 opensm/osm_subnet.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/opensm/osm_subnet.c b/opensm/osm_subnet.c
index 554a950..c8a8add 100644
--- a/opensm/osm_subnet.c
+++ b/opensm/osm_subnet.c
@@ -1159,7 +1159,7 @@ int osm_subn_verify_config(IN osm_subn_opt_t * p_opts)
 		log_report(" Invalid Cached Option Value:console = %s"
 			   ", Using Default:%s\n",
 			   p_opts->console, OSM_DEFAULT_CONSOLE);
-		p_opts->console = OSM_DEFAULT_CONSOLE;
+		p_opts->console = strdup(OSM_DEFAULT_CONSOLE);
 	}
 
 	if (p_opts->qos) {
-- 
1.7.1



--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [opensm] [PATCH 1/2] Fix segfault corner case

[Alex Netes]

Hi Al,

On 10:01 Thu 10 Nov     , Albert Chu wrote:
> On rescan, data segment memory could be attempted to be freed by
> config file parsing code.
> 
> Signed-off-by: Albert L. Chu <chu11-i2BcT+NCU+M@public.gmane.org>
> ---
>  opensm/osm_subnet.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/opensm/osm_subnet.c b/opensm/osm_subnet.c
> index 554a950..c8a8add 100644
> --- a/opensm/osm_subnet.c
> +++ b/opensm/osm_subnet.c
> @@ -1159,7 +1159,7 @@ int osm_subn_verify_config(IN osm_subn_opt_t * p_opts)
>  		log_report(" Invalid Cached Option Value:console = %s"
>  			   ", Using Default:%s\n",
>  			   p_opts->console, OSM_DEFAULT_CONSOLE);
> -		p_opts->console = OSM_DEFAULT_CONSOLE;
> +		p_opts->console = strdup(OSM_DEFAULT_CONSOLE);

If console is set to a wrong value, you get some memory leak here, because
strdup() allocates new buffer and the old one is never free.

>  	}
>  
>  	if (p_opts->qos) {
> -- 
> 1.7.1
> 
> 
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
> the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

-- 

-- Alex
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [opensm] [PATCH 1/2] Fix segfault corner case

[Albert Chu]

On Fri, 2011-11-11 at 04:19 -0800, Alex Netes wrote:
> Hi Al,
> 
> On 10:01 Thu 10 Nov     , Albert Chu wrote:
> > On rescan, data segment memory could be attempted to be freed by
> > config file parsing code.
> > 
> > Signed-off-by: Albert L. Chu <chu11-i2BcT+NCU+M@public.gmane.org>
> > ---
> >  opensm/osm_subnet.c |    2 +-
> >  1 files changed, 1 insertions(+), 1 deletions(-)
> > 
> > diff --git a/opensm/osm_subnet.c b/opensm/osm_subnet.c
> > index 554a950..c8a8add 100644
> > --- a/opensm/osm_subnet.c
> > +++ b/opensm/osm_subnet.c
> > @@ -1159,7 +1159,7 @@ int osm_subn_verify_config(IN osm_subn_opt_t * p_opts)
> >  		log_report(" Invalid Cached Option Value:console = %s"
> >  			   ", Using Default:%s\n",
> >  			   p_opts->console, OSM_DEFAULT_CONSOLE);
> > -		p_opts->console = OSM_DEFAULT_CONSOLE;
> > +		p_opts->console = strdup(OSM_DEFAULT_CONSOLE);
> 
> If console is set to a wrong value, you get some memory leak here, because
> strdup() allocates new buffer and the old one is never free.

Doh!  You're right.  I guess that mem-leak has been there for quite some
time. I'll add that fix and repost.

Al

> >  	}
> >  
> >  	if (p_opts->qos) {
> > -- 
> > 1.7.1
> > 
> > 
> > 
> > --
> > To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
> > the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> > More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 
-- 
Albert Chu
chu11-i2BcT+NCU+M@public.gmane.org
Computer Scientist
High Performance Systems Division
Lawrence Livermore National Laboratory


--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [opensm] [PATCH 1/2] Fix memleak and segfault

[Albert Chu]

If invalid input specified by user, memory would not be freed.

On rescan with new value, data segment memory could be attempted
to be freed.

Signed-off-by: Albert L. Chu <chu11-i2BcT+NCU+M@public.gmane.org>
---
 opensm/osm_subnet.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/opensm/osm_subnet.c b/opensm/osm_subnet.c
index 554a950..9845edd 100644
--- a/opensm/osm_subnet.c
+++ b/opensm/osm_subnet.c
@@ -1159,7 +1159,8 @@ int osm_subn_verify_config(IN osm_subn_opt_t * p_opts)
 		log_report(" Invalid Cached Option Value:console = %s"
 			   ", Using Default:%s\n",
 			   p_opts->console, OSM_DEFAULT_CONSOLE);
-		p_opts->console = OSM_DEFAULT_CONSOLE;
+		free(p_opts->console);
+		p_opts->console = strdup(OSM_DEFAULT_CONSOLE);
 	}
 
 	if (p_opts->qos) {
-- 
1.7.1



--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [opensm] [PATCH 1/2] Fix memleak and segfault

[Alex Netes]

Hi Al,

On 10:04 Fri 11 Nov     , Albert Chu wrote:
> If invalid input specified by user, memory would not be freed.
> 
> On rescan with new value, data segment memory could be attempted
> to be freed.
> 
> Signed-off-by: Albert L. Chu <chu11-i2BcT+NCU+M@public.gmane.org>
> ---

Applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html