From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jason Gunthorpe Subject: Re: [PATCH 4/5] ib/core: add support for extended performance counters in sysfs Date: Tue, 20 Dec 2011 12:50:15 -0700 Message-ID: <20111220195014.GH25774@obsidianresearch.com> References: <20111101173625.GH26974@obsidianresearch.com> <20111101183730.GI26974@obsidianresearch.com> <4EB17AF9.3000608@mellanox.com> <20111108010952.GC4934@obsidianresearch.com> <4EF07993.2090900@mellanox.com> <20111220174639.GE25774@obsidianresearch.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Or Gerlitz Cc: Or Gerlitz , Roland Dreier , linux-rdma List-Id: linux-rdma@vger.kernel.org On Tue, Dec 20, 2011 at 09:40:09PM +0200, Or Gerlitz wrote: > Jason Gunthorpe wrote: > > The netdev counters are all the same size and there is some other way > > to discover what the size is. I'd like to see that for IB counters > > too, but it is probably infeasible. So if we have counters that are > > not the same size as netdev counters then some kind of size indicator > > is required for sane userspace. > > We're talking now only on the IB extended counters who are all 64 bits netdev counters are 32 bit or 64 bit, depending on how the kernel was compiled. I think indicating the size explicitly, or always being 64 bit (and extending all the lessor counters in future) is the way to go for IB.. Jason -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html