public inbox for linux-rdma@vger.kernel.org
 help / color / mirror / Atom feed
From: Ira Weiny <weiny2-i2BcT+NCU+M@public.gmane.org>
To: pierre orzechowski
	<pierre.e.orzechowski-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
Cc: "linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
	<linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: ibswitches command displays wrong information when switch description string includes "base"
Date: Wed, 11 Jan 2012 23:36:54 -0800	[thread overview]
Message-ID: <20120111233654.7b91b2bd.weiny2@llnl.gov> (raw)
In-Reply-To: <4F079048.8050709-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>

While Jason is correct that I am working to deprecate the scripts this bug still exists in the 1.5 branch.

Thanks for pointing this out.  As Open Fabrics is doing an additional 1.5 release I will attempt to fix before that release.

Thanks,
Ira

On Fri, 6 Jan 2012 16:22:32 -0800
pierre orzechowski <pierre.e.orzechowski-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org> wrote:

> Hello,
> 
> We have a customer reporting an issue with the "ibswitches" command part 
> of the infiniband-diags package.
> If the switch description includes the string "base" anywhere, then the 
> match operation in the awk section of ibwitches does not behave as 
> expected and output is garbled.
> 
> Example :
> 
> [root@slcc09sw-ib2 tmp]# grep Switch ibnetdisc.out
> Switch  36 "S-002128468ee1a0a0"         # "SUN DCS 36P QDR basesw-ib3 
> 10.242.48.23" enhanced port 0 lid 1 lmc 0
> Switch  36 "S-0021286cc8a3a0a0"         # "SUN DCS 46P QDR slcc09sw-ib3 
> 10.242.48.24" enhanced port 0 lid 12 lmc 0
> [root@slcc09sw-ib2 tmp]# ibswitches ibnetdisc.out
> Switch  : 0x002128468ee1a0a0 ports 36 "SUN DCS 36P QDR base port 0 lid 1 
> lmc 0
> Switch  : 0x0021286cc8a3a0a0 ports 36 "SUN DCS 46P QDR slcc09sw-ib3 
> 10.242.48.24" enhanced port 0 lid 12 lmc 0
> 
> The 1 liner workaround we have is to replace in red :
> echo "$text" | awk '
> /^Switch/       {
>                          l=$0
>                          desc=substr(l, match(l, "#[ \t]*")+RLENGTH)
>                          pi=match(desc, "port 0.*")
>                          pinfo=substr(desc, pi)
>                          desc=substr(desc, 1, pi-2)
> type="base"
>                          ti=match(desc, type)
> ...
> 
> With
> 
> echo "$text" | awk '
> /^Switch/       {
>                          l=$0
>                          desc=substr(l, match(l, "#[ \t]*")+RLENGTH)
>                          pi=match(desc, "port 0.*")
>                          pinfo=substr(desc, pi)
>                          desc=substr(desc, 1, pi-2)
> type="\base\"
>                          ti=match(desc, type)
> ...
> 
> Thanks for your help in reviewing this potential defect.
> Apologies if posting to the wrong mailing list.
> 
> Best regards,
> Pierre Orzechowski
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
> the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html


-- 
Ira Weiny
Member of Technical Staff
Lawrence Livermore National Lab
925-423-8008
weiny2-i2BcT+NCU+M@public.gmane.org
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

      parent reply	other threads:[~2012-01-12  7:36 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-01-07  0:22 ibswitches command displays wrong information when switch description string includes "base" pierre orzechowski
     [not found] ` <4F079048.8050709-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
2012-01-07  0:51   ` Jason Gunthorpe
2012-01-12  7:36   ` Ira Weiny [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120111233654.7b91b2bd.weiny2@llnl.gov \
    --to=weiny2-i2bct+ncu+m@public.gmane.org \
    --cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=pierre.e.orzechowski-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox