public inbox for linux-rdma@vger.kernel.org
 help / color / mirror / Atom feed
From: Jason Gunthorpe <jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
To: Mike Marciniszyn
	<mike.marciniszyn-h88ZbnxC6KDQT0dZR+AlfA@public.gmane.org>
Cc: "roland-BHEL68pLQRGGvPXPguhicg@public.gmane.org"
	<roland-BHEL68pLQRGGvPXPguhicg@public.gmane.org>,
	"linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
	<linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [PATCH] IB/qib: detour pcie_caps for certain chip sets
Date: Thu, 12 Jan 2012 13:27:50 -0700	[thread overview]
Message-ID: <20120112202750.GG31021@obsidianresearch.com> (raw)
In-Reply-To: <35AAF1E4A771E142979F27B51793A4888885A5E388-HolNjIBXvBOXx9kJd3VG2h2eb7JE58TQ@public.gmane.org>

On Thu, Jan 12, 2012 at 08:02:52AM -0800, Mike Marciniszyn wrote:
> > Should whatever this issue is be a general PCI fixup? Like broken MSI,
> > etc.
> >
> Can you point me to some details on this?

I can explain the broken MSI stuff, as an example. As I noted I'm not
sure what you are working around here, but if there are limits imposed
on otherwise correct values in the PCI capabilities block then I think
it is broadly applicable to handle this in core code...

There are flags in pci.h like:

        PCI_BUS_FLAGS_NO_MSI   = (__force pci_bus_flags_t) 1,

Which are quirk things.. Look in drivers/pci/quirks.c to see how it is
set.

So broadly you'd make a new appropriate bus flag to control
whatever you are working around and then test and set it in quirks,
and provide core code to traverse the bus path from a device to ensure
nothing in the path sets that quirk.

Really depends what the problem actually is.

Jason
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  parent reply	other threads:[~2012-01-12 20:27 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-01-12  3:00 [PATCH] IB/qib: detour pcie_caps for certain chip sets Mike Marciniszyn
     [not found] ` <20120112030049.31831.62692.stgit-hIFRcJ1SNwcXGO8/Qfapyjg/wwJxntczYPYVAmT7z5s@public.gmane.org>
2012-01-12  5:48   ` Jason Gunthorpe
     [not found]     ` <20120112054830.GB32082-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2012-01-12  7:06       ` Roland Dreier
2012-01-12 16:02       ` Mike Marciniszyn
     [not found]         ` <35AAF1E4A771E142979F27B51793A4888885A5E388-HolNjIBXvBOXx9kJd3VG2h2eb7JE58TQ@public.gmane.org>
2012-01-12 20:27           ` Jason Gunthorpe [this message]
2012-01-12  7:06   ` Roland Dreier
     [not found]     ` <CAL1RGDXOO6baaET_fCFT3YUsK9aqGkODoHnd1FNwOp_szZO4Gw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-01-12 17:17       ` Mike Marciniszyn
     [not found]         ` <35AAF1E4A771E142979F27B51793A4888885A5E3AE-HolNjIBXvBOXx9kJd3VG2h2eb7JE58TQ@public.gmane.org>
2012-01-12 21:57           ` Roland Dreier
     [not found]             ` <CAL1RGDW2DcU_kp46BfRJjQjkEYxcCqRzqdgOC-AAhUsXsDb8gQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-01-12 22:14               ` Mike Marciniszyn
     [not found]                 ` <35AAF1E4A771E142979F27B51793A4888885A5E45C-HolNjIBXvBOXx9kJd3VG2h2eb7JE58TQ@public.gmane.org>
2012-01-12 22:23                   ` Jason Gunthorpe
     [not found]                     ` <20120112222328.GI31021-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2012-01-12 22:35                       ` Mike Marciniszyn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120112202750.GG31021@obsidianresearch.com \
    --to=jgunthorpe-epgobjl8dl3ta4ec/59zmfatqe2ktcn/@public.gmane.org \
    --cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=mike.marciniszyn-h88ZbnxC6KDQT0dZR+AlfA@public.gmane.org \
    --cc=roland-BHEL68pLQRGGvPXPguhicg@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox