From: Jason Gunthorpe <jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
To: Flavio Baronti <f.baronti-ngIpsMLAhaq41k5uCYKmRQ@public.gmane.org>
Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: Leak in rdma_get_cm_event on pthread_cancel?
Date: Fri, 13 Jan 2012 10:59:25 -0700 [thread overview]
Message-ID: <20120113175925.GE6798@obsidianresearch.com> (raw)
In-Reply-To: <4F101978.6010608-ngIpsMLAhaq41k5uCYKmRQ@public.gmane.org>
On Fri, Jan 13, 2012 at 12:46:00PM +0100, Flavio Baronti wrote:
> When I want to stop the thread reading rdma events, I kill it with a
> pthread_cancel(), since it is blocked in a rdma_get_cm_event(). This
> causes a leak of the evt variable in the rdma_get_cm_event()
> function. Not a big deal, of course, but a couple of
> pthread_cleanup_push(free, evt) and pthread_cleanup_pop() should
> solve it.
None of the IB libraries have been audited for posix async cancellation
safety.
To do this work someone would have to review every call to determine
if it is a cancelation point, and document this as part of the API.
Then review if any of the internal cancelation points in the
cancelable functions require a resource clean up, and add it.
IHMO, cancelation should not be used with threads that call into the
ib libraries.
Jason
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2012-01-13 17:59 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-13 11:46 Leak in rdma_get_cm_event on pthread_cancel? Flavio Baronti
[not found] ` <4F101978.6010608-ngIpsMLAhaq41k5uCYKmRQ@public.gmane.org>
2012-01-13 16:43 ` Hefty, Sean
[not found] ` <1828884A29C6694DAF28B7E6B8A8237325676E37-P5GAC/sN6hmkrb+BlOpmy7fspsVTdybXVpNB7YpNyf8@public.gmane.org>
2012-01-13 16:55 ` Flavio Baronti
2012-01-13 17:59 ` Jason Gunthorpe [this message]
[not found] ` <20120113175925.GE6798-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2012-01-16 8:46 ` Flavio Baronti
[not found] ` <4F13E3ED.3010708-ngIpsMLAhaq41k5uCYKmRQ@public.gmane.org>
2012-01-16 22:15 ` Or Gerlitz
[not found] ` <CAJZOPZ+ik7DdXJHbEyr-PKyOQ3yEoWa6H=rhEe4cwc__61DUrQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-01-16 22:35 ` Jason Gunthorpe
[not found] ` <20120116223541.GA2892-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2012-01-17 8:52 ` Flavio Baronti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120113175925.GE6798@obsidianresearch.com \
--to=jgunthorpe-epgobjl8dl3ta4ec/59zmfatqe2ktcn/@public.gmane.org \
--cc=f.baronti-ngIpsMLAhaq41k5uCYKmRQ@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox