* [patch] infiniband: calling PTR_ERR() on wrong variable in create_file()
@ 2012-01-26 6:15 Dan Carpenter
[not found] ` <20120126061529.GC15856-mgFCXtclrQlZLf2FXnZxJA@public.gmane.org>
0 siblings, 1 reply; 3+ messages in thread
From: Dan Carpenter @ 2012-01-26 6:15 UTC (permalink / raw)
To: Mike Marciniszyn
Cc: Roland Dreier, Sean Hefty, Hal Rosenstock,
linux-rdma-u79uwXL29TY76Z2rM5mHXA,
kernel-janitors-u79uwXL29TY76Z2rM5mHXA
"dentry" is a valid pointer. "*dentry" was intended.
Signed-off-by: Dan Carpenter <dan.carpenter-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
diff --git a/drivers/infiniband/hw/ipath/ipath_fs.c b/drivers/infiniband/hw/ipath/ipath_fs.c
index b7d4216..a4de9d5 100644
--- a/drivers/infiniband/hw/ipath/ipath_fs.c
+++ b/drivers/infiniband/hw/ipath/ipath_fs.c
@@ -89,7 +89,7 @@ static int create_file(const char *name, umode_t mode,
error = ipathfs_mknod(parent->d_inode, *dentry,
mode, fops, data);
else
- error = PTR_ERR(dentry);
+ error = PTR_ERR(*dentry);
mutex_unlock(&parent->d_inode->i_mutex);
return error;
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related [flat|nested] 3+ messages in thread[parent not found: <20120126061529.GC15856-mgFCXtclrQlZLf2FXnZxJA@public.gmane.org>]
* RE: [patch] infiniband: calling PTR_ERR() on wrong variable in create_file() [not found] ` <20120126061529.GC15856-mgFCXtclrQlZLf2FXnZxJA@public.gmane.org> @ 2012-01-26 13:20 ` Mike Marciniszyn [not found] ` <35AAF1E4A771E142979F27B51793A4888885B23834-HolNjIBXvBOXx9kJd3VG2h2eb7JE58TQ@public.gmane.org> 0 siblings, 1 reply; 3+ messages in thread From: Mike Marciniszyn @ 2012-01-26 13:20 UTC (permalink / raw) To: Dan Carpenter, Dept-ENG Infinipath Cc: Roland Dreier, Sean Hefty, Hal Rosenstock, linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, kernel-janitors-u79uwXL29TY76Z2rM5mHXA@public.gmane.org > From: Dan Carpenter [mailto:dan.carpenter-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org] > Subject: [patch] infiniband: calling PTR_ERR() on wrong variable in > > Signed-off-by: Dan Carpenter <dan.carpenter-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org> > I double checked the qib driver, and the equivalent code is ok there. Thanks for the patch! Acked-by: Mike Marciniszyn <mike.marciniszyn-h88ZbnxC6KDQT0dZR+AlfA@public.gmane.org> This message and any attached documents contain information from QLogic Corporation or its wholly-owned subsidiaries that may be confidential. If you are not the intended recipient, you may not read, copy, distribute, or use this information. If you have received this transmission in error, please notify the sender immediately by reply e-mail and then delete this message. -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 3+ messages in thread
[parent not found: <35AAF1E4A771E142979F27B51793A4888885B23834-HolNjIBXvBOXx9kJd3VG2h2eb7JE58TQ@public.gmane.org>]
* Re: [patch] infiniband: calling PTR_ERR() on wrong variable in create_file() [not found] ` <35AAF1E4A771E142979F27B51793A4888885B23834-HolNjIBXvBOXx9kJd3VG2h2eb7JE58TQ@public.gmane.org> @ 2012-01-27 17:48 ` Roland Dreier 0 siblings, 0 replies; 3+ messages in thread From: Roland Dreier @ 2012-01-27 17:48 UTC (permalink / raw) To: Mike Marciniszyn Cc: Dan Carpenter, Dept-ENG Infinipath, Sean Hefty, Hal Rosenstock, linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, kernel-janitors-u79uwXL29TY76Z2rM5mHXA@public.gmane.org Thanks, applied. -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-01-27 17:48 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-01-26 6:15 [patch] infiniband: calling PTR_ERR() on wrong variable in create_file() Dan Carpenter
[not found] ` <20120126061529.GC15856-mgFCXtclrQlZLf2FXnZxJA@public.gmane.org>
2012-01-26 13:20 ` Mike Marciniszyn
[not found] ` <35AAF1E4A771E142979F27B51793A4888885B23834-HolNjIBXvBOXx9kJd3VG2h2eb7JE58TQ@public.gmane.org>
2012-01-27 17:48 ` Roland Dreier
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox