public inbox for linux-rdma@vger.kernel.org
 help / color / mirror / Atom feed
From: Kyle McMartin <kmcmartin-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
To: linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Cc: hnguyen-tA70FqPdS9bQT0dZR+AlfA@public.gmane.org,
	raisch-tA70FqPdS9bQT0dZR+AlfA@public.gmane.org
Subject: [PATCH] ib_ehca: fix compile failure on ppc64
Date: Mon, 27 Feb 2012 17:02:56 -0500	[thread overview]
Message-ID: <20120227220255.GE29211@redacted.bos.redhat.com> (raw)

I'm getting compile failures building this driver, which I narrowed down
to the ilog2 call in ehca_get_max_hwpage_size...

ERROR: ".____ilog2_NaN" [drivers/infiniband/hw/ehca/ib_ehca.ko]
undefined!
make[1]: *** [__modpost] Error 1
make: *** [modules] Error 2

The use of shca->hca_cap_mr_pgsize is confusing the compiler, and
resulting in the __builtin_constant_p in ilog2 going insane.

I tried making it take the u32 pgsize as an argument and the expansion
of shca->_pgsize in the caller, but that failed as well. Adding a
temporary variable as below got it building again though (as did
replacing the ilog2 with fls(x) - 1.)

With this patch in place, the driver compiles on my GCC 4.6.2 here.

Signed-off-by: Kyle McMartin <kmcmarti-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>

--- a/drivers/infiniband/hw/ehca/ehca_mrmw.c
+++ b/drivers/infiniband/hw/ehca/ehca_mrmw.c
@@ -112,7 +112,8 @@ static u32 ehca_encode_hwpage_size(u32 pgsize)
 
 static u64 ehca_get_max_hwpage_size(struct ehca_shca *shca)
 {
-	return 1UL << ilog2(shca->hca_cap_mr_pgsize);
+	u32 pgsize = shca->hca_cap_mr_pgsize;
+	return 1UL << ilog2(pgsize);
 }
 
 static struct ehca_mr *ehca_mr_new(void)
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

             reply	other threads:[~2012-02-27 22:02 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-02-27 22:02 Kyle McMartin [this message]
     [not found] ` <20120227220255.GE29211-nxOev/eQj6CGu0OVIAPS5KfLeoKvNuZc@public.gmane.org>
2012-02-28  5:18   ` [PATCH] ib_ehca: fix compile failure on ppc64 Roland Dreier
     [not found]     ` <CAL1RGDXjF-Y-UABiondu6y9k9HRoxgE9oVAbp-BJ4x+iuRjiWg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-02-28 15:15       ` Kyle McMartin
     [not found]         ` <20120228151545.GF29211-nxOev/eQj6CGu0OVIAPS5KfLeoKvNuZc@public.gmane.org>
2012-03-19 10:05           ` Hoang-Nam Nguyen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120227220255.GE29211@redacted.bos.redhat.com \
    --to=kmcmartin-h+wxahxf7alqt0dzr+alfa@public.gmane.org \
    --cc=hnguyen-tA70FqPdS9bQT0dZR+AlfA@public.gmane.org \
    --cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=raisch-tA70FqPdS9bQT0dZR+AlfA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox