public inbox for linux-rdma@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] libibverbs-xrc: Rename the attribute private -> private_data
@ 2012-04-24  6:13 Dotan Barak
       [not found] ` <201204240913.59380.dotanb-g2bIKuvJtcQanlnWow0HJg@public.gmane.org>
  0 siblings, 1 reply; 2+ messages in thread
From: Dotan Barak @ 2012-04-24  6:13 UTC (permalink / raw)
  To: Sean Hefty; +Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA

Since "private" is a reserved word in C++, it shouldn't be used as a name of a
structure attribute.

Signed-off-by: Dotan Barak <dotanb-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>
Reviewed-by: Jack Morgenstein <jackm-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>
---
 include/infiniband/ofverbs.h |    2 +-
 include/infiniband/verbs.h   |    4 ++--
 src/ofverbs.c                |    4 ++--
 3 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/include/infiniband/ofverbs.h b/include/infiniband/ofverbs.h
index b03d7ae..841e689 100644
--- a/include/infiniband/ofverbs.h
+++ b/include/infiniband/ofverbs.h
@@ -102,7 +102,7 @@ struct ofv_async_event {
 		uint32_t	xrc_qp_num;
 	} element;
 	enum ibv_event_type	event_type;
-	void                   *private;
+	void                   *private_data;
 };
 
 int ofv_get_async_event(struct ibv_context *context,
diff --git a/include/infiniband/verbs.h b/include/infiniband/verbs.h
index 1dcd17f..ddc8722 100644
--- a/include/infiniband/verbs.h
+++ b/include/infiniband/verbs.h
@@ -706,7 +706,7 @@ struct ibv_device {
 	char			ibdev_path[IBV_SYSFS_PATH_MAX];
 
 	/* Following fields only available if device supports extensions */
-	void		       *private;
+	void		       *private_data;
 	int			(*have_ext_ops)(struct ibv_device *device,
 						const char *ext_name);
 	void *			(*get_device_ext_ops)(struct ibv_device *device,
@@ -791,7 +791,7 @@ struct ibv_context {
 	void		       *abi_compat;
 
 	/* Following fields only available if device supports extensions */
-	void		       *private;
+	void		       *private_data;
 	void *			(*get_ext_ops)(struct ibv_context *context,
 					       const char *ext_name);
 };
diff --git a/src/ofverbs.c b/src/ofverbs.c
index 0486552..2ee5e81 100644
--- a/src/ofverbs.c
+++ b/src/ofverbs.c
@@ -61,7 +61,7 @@ int __ofv_get_async_event(struct ibv_context *context,
 		case IBV_EVENT_PATH_MIG_ERR:
 		case IBV_EVENT_QP_LAST_WQE_REACHED:
 			if (event->element.qp->qp_type == IBV_QPT_XRC_RECV) {
-				event->private = event->element.qp;
+				event->private_data = event->element.qp;
 				event->event_type |= OFV_XRC_QP_EVENT_FLAG;
 				event->element.xrc_qp_num = event->element.qp->qp_num;
 			}
@@ -76,7 +76,7 @@ default_symver(__ofv_get_async_event, ofv_get_async_event);
 void ofv_ack_async_event(struct ofv_async_event *event)
 {
 	if (event->event_type & OFV_XRC_QP_EVENT_FLAG) {
-		event->element.qp = event->private;
+		event->element.qp = event->private_data;
 		event->event_type &= ~OFV_XRC_QP_EVENT_FLAG;
 	}
 	ibv_ack_async_event((struct ibv_async_event *) event);
-- 
1.7.8.2

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* RE: [PATCH] libibverbs-xrc: Rename the attribute private -> private_data
       [not found] ` <201204240913.59380.dotanb-g2bIKuvJtcQanlnWow0HJg@public.gmane.org>
@ 2012-04-24 18:59   ` Hefty, Sean
  0 siblings, 0 replies; 2+ messages in thread
From: Hefty, Sean @ 2012-04-24 18:59 UTC (permalink / raw)
  To: Dotan Barak; +Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org

thanks - applied
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2012-04-24 18:59 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-04-24  6:13 [PATCH] libibverbs-xrc: Rename the attribute private -> private_data Dotan Barak
     [not found] ` <201204240913.59380.dotanb-g2bIKuvJtcQanlnWow0HJg@public.gmane.org>
2012-04-24 18:59   ` Hefty, Sean

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox