From: Dotan Barak <dotanb-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>
To: Sean Hefty <sean.hefty-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: [PATCH][TRIVIAL] rping: security fix: replace sprintf with snprintf
Date: Tue, 24 Apr 2012 14:38:28 +0300 [thread overview]
Message-ID: <201204241438.28483.dotanb@sw.voltaire.com> (raw)
Replace sprintf with snprintf to protects from buffer overflow.
Signed-off-by: Dotan Barak <dotanb-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>
---
examples/rping.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/examples/rping.c b/examples/rping.c
index ee292ec..785338e 100644
--- a/examples/rping.c
+++ b/examples/rping.c
@@ -909,7 +909,7 @@ static int rping_test_client(struct rping_cb *cb)
cb->state = RDMA_READ_ADV;
/* Put some ascii text in the buffer. */
- cc = sprintf(cb->start_buf, RPING_MSG_FMT, ping);
+ cc = snprintf(cb->start_buf, cb->size, RPING_MSG_FMT, ping);
for (i = cc, c = start; i < cb->size; i++) {
cb->start_buf[i] = c;
c++;
--
1.7.8.2
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next reply other threads:[~2012-04-24 11:38 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-24 11:38 Dotan Barak [this message]
[not found] ` <201204241438.28483.dotanb-g2bIKuvJtcQanlnWow0HJg@public.gmane.org>
2012-04-24 18:25 ` [PATCH][TRIVIAL] rping: security fix: replace sprintf with snprintf Hefty, Sean
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201204241438.28483.dotanb@sw.voltaire.com \
--to=dotanb-ldsdmyg8hgv8yrgs2mwiifqbs+8scbdb@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=sean.hefty-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox