From: Ira Weiny <weiny2-i2BcT+NCU+M@public.gmane.org>
To: Hal Rosenstock <hal-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>
Cc: Jim Foraker <foraker1-i2BcT+NCU+M@public.gmane.org>,
linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH V3 1/8] infiniband-diags: Obfuscate sensitive output by default
Date: Thu, 31 May 2012 08:10:08 -0700 [thread overview]
Message-ID: <20120531081008.f54f9a08.weiny2@llnl.gov> (raw)
In-Reply-To: <4FC75A8D.4080305-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>
On Thu, 31 May 2012 07:48:29 -0400
Hal Rosenstock <hal-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org> wrote:
> On 5/30/2012 1:21 PM, Jim Foraker wrote:
> > Cause security credentials to not be displayed by default. Instead,
> > the "-K" flag is supported, which must be passed to the command
> > to display valid results.
> >
> > Signed-off-by: Jim Foraker <foraker1-i2BcT+NCU+M@public.gmane.org>
> > ---
> > doc/rst/common/opt_K.rst | 4 +++
> > doc/rst/saquery.8.in.rst | 2 ++
> > doc/rst/smpquery.8.in.rst | 2 ++
> > include/ibdiag_common.h | 9 ++++++
> > src/ibaddr.c | 2 +-
> > src/ibcacheedit.c | 2 +-
> > src/ibccconfig.c | 2 +-
> > src/ibccquery.c | 2 +-
> > src/ibdiag_common.c | 71 +++++++++++++++++++++++++++++++++++++++++++++
> > src/iblinkinfo.c | 2 +-
> > src/ibnetdiscover.c | 2 +-
> > src/ibping.c | 2 +-
> > src/ibqueryerrors.c | 2 +-
> > src/ibroute.c | 2 +-
> > src/ibsendtrap.c | 2 +-
> > src/ibstat.c | 2 +-
> > src/ibsysstat.c | 2 +-
> > src/ibtracert.c | 2 +-
> > src/perfquery.c | 2 +-
> > src/saquery.c | 66 ++++++++++++++++++++---------------------
> > src/sminfo.c | 2 +-
> > src/smpdump.c | 2 +-
> > src/smpquery.c | 6 ++--
> > src/vendstat.c | 2 +-
> > 24 files changed, 139 insertions(+), 55 deletions(-)
> > create mode 100644 doc/rst/common/opt_K.rst
>
> Do all these tools display keys ? AFAIK ibping, ibstat, ibsysstat,
> perfquery, and vendstat don't.
No they don't which is why the patch excludes the common option "-K" in ibdiag_process_opts.
Ira
>
> -- Hal
>
--
Ira Weiny
Member of Technical Staff
Lawrence Livermore National Lab
925-423-8008
weiny2-i2BcT+NCU+M@public.gmane.org
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2012-05-31 15:10 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-30 17:20 [PATCH v3 0/8] Mkey support in infiniband-diags Jim Foraker
[not found] ` <1338398414.11948.29.camel-mxTxeWJot8FliZ7u+bvwcg@public.gmane.org>
2012-05-30 17:21 ` [PATCH V3 1/8] infiniband-diags: Obfuscate sensitive output by default Jim Foraker
[not found] ` <1338398497-12444-1-git-send-email-foraker1-i2BcT+NCU+M@public.gmane.org>
2012-05-30 17:21 ` [PATCH V3 2/8] infiniband-diags: install config file mode 400 Jim Foraker
[not found] ` <1338398497-12444-2-git-send-email-foraker1-i2BcT+NCU+M@public.gmane.org>
2012-05-31 22:15 ` Ira Weiny
2012-05-30 17:21 ` [PATCH V3 3/8] infiniband-diags/ibportstate.c: Display MKey, lease, and protect bits Jim Foraker
[not found] ` <1338398497-12444-3-git-send-email-foraker1-i2BcT+NCU+M@public.gmane.org>
2012-05-31 22:16 ` Ira Weiny
2012-05-30 17:21 ` [PATCH V3 4/8] infiniband-diags: Allow specification of an mkey to use on the command line Jim Foraker
[not found] ` <1338398497-12444-4-git-send-email-foraker1-i2BcT+NCU+M@public.gmane.org>
2012-05-31 11:48 ` Hal Rosenstock
[not found] ` <4FC75A97.7080106-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>
2012-05-31 15:18 ` Ira Weiny
2012-05-31 19:08 ` Jim Foraker
[not found] ` <1338491297.19133.30.camel-mxTxeWJot8FliZ7u+bvwcg@public.gmane.org>
2012-05-31 19:11 ` [PATCH V3.1 " Jim Foraker
[not found] ` <1338491493-19714-1-git-send-email-foraker1-i2BcT+NCU+M@public.gmane.org>
2012-05-31 22:17 ` Ira Weiny
2012-05-30 17:21 ` [PATCH V3 5/8] infiniband-diags/ibportstate.c: Support changing MKey, lease, and protect bits Jim Foraker
[not found] ` <1338398497-12444-5-git-send-email-foraker1-i2BcT+NCU+M@public.gmane.org>
2012-05-31 22:21 ` Ira Weiny
2012-05-30 17:21 ` [PATCH V3 6/8] infiniband-diags: Add m_key option to config file Jim Foraker
[not found] ` <1338398497-12444-6-git-send-email-foraker1-i2BcT+NCU+M@public.gmane.org>
2012-05-31 22:22 ` Ira Weiny
2012-05-30 17:21 ` [PATCH V3 7/8] ib-diags/saquery: Fix smkey handling Jim Foraker
[not found] ` <1338398497-12444-7-git-send-email-foraker1-i2BcT+NCU+M@public.gmane.org>
2012-05-30 22:14 ` [PATCH V3.1 " Jim Foraker
[not found] ` <1338416060-14025-1-git-send-email-foraker1-i2BcT+NCU+M@public.gmane.org>
2012-05-31 22:23 ` Ira Weiny
2012-05-30 17:21 ` [PATCH V3 8/8] infiniband-diags: Add sa_smkey option to config file Jim Foraker
[not found] ` <1338398497-12444-8-git-send-email-foraker1-i2BcT+NCU+M@public.gmane.org>
2012-05-30 18:06 ` Hal Rosenstock
[not found] ` <4FC66196.5030704-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>
2012-05-30 18:43 ` Jim Foraker
[not found] ` <1338403407.17237.860.camel-mxTxeWJot8FliZ7u+bvwcg@public.gmane.org>
2012-05-30 22:17 ` Jim Foraker
2012-05-30 22:15 ` [PATCH V3.1 " Jim Foraker
[not found] ` <1338416114-14068-1-git-send-email-foraker1-i2BcT+NCU+M@public.gmane.org>
2012-05-31 11:56 ` Hal Rosenstock
[not found] ` <4FC75C61.7060408-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>
2012-05-31 22:25 ` Ira Weiny
[not found] ` <20120531152515.410a999a.weiny2-i2BcT+NCU+M@public.gmane.org>
2012-05-31 23:30 ` Hal Rosenstock
[not found] ` <4FC7FF07.6090207-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>
2012-05-31 23:54 ` Ira Weiny
2012-05-31 22:23 ` Ira Weiny
2012-05-31 11:48 ` [PATCH V3 1/8] infiniband-diags: Obfuscate sensitive output by default Hal Rosenstock
[not found] ` <4FC75A8D.4080305-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>
2012-05-31 15:10 ` Ira Weiny [this message]
2012-05-31 22:15 ` Ira Weiny
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120531081008.f54f9a08.weiny2@llnl.gov \
--to=weiny2-i2bct+ncu+m@public.gmane.org \
--cc=foraker1-i2BcT+NCU+M@public.gmane.org \
--cc=hal-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox