From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ira Weiny Subject: Re: [PATCH V3 4/8] infiniband-diags: Allow specification of an mkey to use on the command line Date: Thu, 31 May 2012 08:18:01 -0700 Message-ID: <20120531081801.62ccd8b1.weiny2@llnl.gov> References: <1338398414.11948.29.camel@auk75.llnl.gov> <1338398497-12444-1-git-send-email-foraker1@llnl.gov> <1338398497-12444-4-git-send-email-foraker1@llnl.gov> <4FC75A97.7080106@dev.mellanox.co.il> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <4FC75A97.7080106-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org> Sender: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Hal Rosenstock Cc: Jim Foraker , linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-rdma@vger.kernel.org On Thu, 31 May 2012 07:48:39 -0400 Hal Rosenstock wrote: > On 5/30/2012 1:21 PM, Jim Foraker wrote: > > Signed-off-by: Jim Foraker > > --- > > doc/rst/common/opt_m.rst | 6 ++++++ > > doc/rst/ibaddr.8.in.rst | 1 + > > doc/rst/ibccconfig.8.in.rst | 1 + > > doc/rst/ibccquery.8.in.rst | 1 + > > doc/rst/iblinkinfo.8.in.rst | 1 + > > doc/rst/ibnetdiscover.8.in.rst | 1 + > > doc/rst/ibportstate.8.in.rst | 1 + > > doc/rst/ibqueryerrors.8.in.rst | 1 + > > doc/rst/ibroute.8.in.rst | 1 + > > doc/rst/ibtracert.8.in.rst | 6 ++++++ > > doc/rst/perfquery.8.in.rst | 1 + > > doc/rst/sminfo.8.in.rst | 1 + > > doc/rst/smpquery.8.in.rst | 1 + > > include/ibdiag_common.h | 1 + > > libibnetdisc/include/infiniband/ibnetdisc.h | 3 ++- > > libibnetdisc/src/ibnetdisc.c | 1 + > > src/ibaddr.c | 2 ++ > > src/ibcacheedit.c | 2 +- > > src/ibccconfig.c | 2 ++ > > src/ibccquery.c | 2 ++ > > src/ibdiag_common.c | 13 +++++++++++++ > > src/iblinkinfo.c | 3 +++ > > src/ibnetdiscover.c | 2 +- > > src/ibping.c | 2 +- > > src/ibportstate.c | 2 ++ > > src/ibqueryerrors.c | 3 +++ > > src/ibroute.c | 2 ++ > > src/ibsendtrap.c | 2 ++ > > src/ibstat.c | 2 +- > > src/ibsysstat.c | 2 +- > > src/ibtracert.c | 4 +++- > > src/perfquery.c | 2 ++ > > src/saquery.c | 2 +- > > src/sminfo.c | 2 ++ > > src/smpquery.c | 2 ++ > > src/vendstat.c | 2 +- > > 36 files changed, 74 insertions(+), 9 deletions(-) > > create mode 100644 doc/rst/common/opt_m.rst > > Do all these tools require mkeys ? AFAIK ibping, ibstat, ibsysstat, > perfquery, and vendstat don't. Same issue here as with the "-K" common option. > > Also, for ibccquery/config why is mkey needed ? What about cckey ? Because ibccquery still does SMP NodeInfo queries for some information about nodes. I think cckey will be a separate patch. Indeed it will probably use "-K" for obfuscation. One thing at a time... ;-) Ira > > -- Hal -- Ira Weiny Member of Technical Staff Lawrence Livermore National Lab 925-423-8008 weiny2-i2BcT+NCU+M@public.gmane.org -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html